-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3.0 support #2453
Comments
I'll start by importing the CRuby 3.0.2 files and report here when done. |
@wildmaples and I can handle keyword argument as part of our current work. Do you want to note that down to avoid conflict? |
OK, I added you in the description for keyword arguments-related changes. |
headius also had that for jruby recently for ruby 3.x - are you folks doing a friendly competition race? :) On a more on-topic note (but applicable to jruby too) - I don't know of a simple way, but like if it would be |
@rubyFeedback Some of the points above can be implemented with only Ruby code (e.g., if the mentioned method is already implemented in Ruby or if it's a new method which seems like it can be implemented with Ruby code). Those are generally all relatively easy. We could potentially do a list of the points which seem easy contributions. |
I annotated Ractor as |
I annotated each change above with
If you'd like to start on some task please mention it here or edit the description directly for committers. |
@eregon I would like to try some easy java task |
@gogainda Then any task which is
|
@eregon thanks, lets assign it to myself then |
Here are the docs to run specs for 3.0 behavior, until the RUBY_VERSION is bumped: https://github.com/oracle/truffleruby/blob/3e03bed224076c2c301a2490a052568a2d013cfe/doc/contributor/workflow.md#running-specs-for-ruby-30-features |
By accident fixed "Module#attr_accessor, Module#attr_reader, Module#attr_writer and Module#attr |
I've started importing files from CRuby 3.0.2, it's going well but it's going to take a bit longer to merge it and fix the CI. |
Hey @eregon I start working on this item
and I've noticed that if I run specs with for name in drop drop_while flatten slice element_reference take take_while uniq multiply; do PRETEND_RUBY_VERSION=3.0.2 bin/jt --use ruby test spec/ruby/core/array/$name\_spec.rb; done; echo "exit=$?"
...
...
...
exit=0 But I don't trust my eyes. So I have a question: Is there a way to build truffleruby with towards Ruby 3 (instead of 2.7) and play in the REPL? |
@Strech You can just use In the above command you have |
Thanks @eregon, I did manage to run the REPL, but the issue is that I would like to test some ❯❯❯ bin/jt ruby -v
Using Interpreted TruffleRuby: mxbuild/truffleruby-jvm
$ ~/truffleruby/mxbuild/truffleruby-jvm/languages/ruby/bin/ruby \
--experimental-options \
--core-load-path=~/truffleruby/src/main/ruby/truffleruby \
-v
truffleruby 22.0.0-dev-f87d531b, like ruby 2.7.4, Interpreted JVM [x86_64-darwin] So the question was about the Ruby version, if I can run specs with |
No, |
Gotcha @ccocchi, will look for something else 👍🏼 |
@eregon Then I'm going to take perform check
|
Noted! |
If no one mind will take this one to check
|
Go ahead :) |
Going to take a look into this one
|
For ruby 3.1.0, I noticed that nobu changed time.rb a bit. I do not know whether this affects truffleruby or not, but I forgot which part it was (somewhere on github of ruby |
@rubyFeedback We import |
TruffleRuby now fully implements Ruby 3 keyword arguments since b8086af and that will be in the 22.1 release. |
Just noting here that released TruffleRuby 22.0.0.2 reports itself as You can see a test that needs to check for TruffleRuby to workaround this behavior here: |
@eregon I would like to try a medium-level difficulty issue
|
Noted. |
@eregon If you don't mind I will try to tackle this issue
|
@Strech Alright. Something to know about this, TruffleRuby did not have the warning and never implemented the "overtaking semantics" of class variables, because it's unreasonably slow and nobody wants those semantics anyway. An example of it is https://bugs.ruby-lang.org/issues/14541#note-31. So I'd suggest for this item to only raise if a class var is assigned at the top-level, and ignore anything overtaking-related. |
Most of it is now done and was in the 22.0 release. I'll close this issue and we can address the remaining items when it becomes possible or important for compatibility. |
We plan to work on Ruby 3.0 support for the next release, TruffleRuby/GraalVM 22.0.
Any help is appreciated whether it is:
See this comment: #2453 (comment) for finding good getting-started issues.
See https://github.com/oracle/truffleruby/blob/3e03bed224076c2c301a2490a052568a2d013cfe/doc/contributor/workflow.md#running-specs-for-ruby-30-features for how to run specs for 3.0.
Notes
Full list of changes for Ruby 3.0.0
NOTE: https://rubyreferences.github.io/rubychanges/3.0.html gives more details for many features and changes.
From https://github.com/ruby/ruby/blob/master/doc/NEWS-3.0.0.md and ruby/spec#823:
This document is a list of user visible feature changes
since the 2.7.0 release, except for bug fixes.
Note that each entry is kept to a minimum, see links for details.
Language changes
See jruby/jruby#6880 regarding parser changes.
@eregon @chrisseaton @wildmaples Keyword arguments are now separated from positional arguments.
Code that resulted in deprecation warnings in Ruby 2.7 will now
result in ArgumentError or different behavior. [Feature #14183]
@eregon Procs accepting a single rest argument and keywords are no longer
subject to autosplatting. This now matches the behavior of Procs
accepting a single rest argument and no keywords.
[Feature #16166]
[parser, hard] Arguments forwarding (
...
) now supports leading arguments.[Feature #16378]
@razetime [parser, hard] Pattern matching (
case/in
) is no longer experimental. [Feature #17260]@razetime [parser, hard] One-line pattern matching is redesigned. [EXPERIMENTAL]
=>
is added. It can be used like a rightward assignment.[Feature #17260]
in
is changed to returntrue
orfalse
. [Feature #17371]@razetime [parser, hard] Find-pattern is added. [EXPERIMENTAL]
[Feature #16828]
[parser, hard] Endless method definition is added. [EXPERIMENTAL]
[Feature #16746]
[easy, undo some of Make interpolated strings frozen #2304] @bjfish Interpolated String literals are no longer frozen when
# frozen-string-literal: true
is used. [Feature #17104][translator, medium] Magic comment
shareable_constant_value
added to freeze constants.See {Magic Comments}[rdoc-ref:doc/syntax/comments.rdoc@Magic+Comments] for more details.
[Feature #17273]
[already the case] Deprecation warnings are no longer shown by default (since Ruby 2.7.2).
Turn them on with
-W:deprecated
(or with-w
to show other warnings too).[Feature #16345]
@bjfish [cleanup, easy]
$SAFE
and$KCODE
are now normal global variables with no special behavior.C-API methods related to
$SAFE
have been removed.[Feature #16131] [Feature #17136]
@Strech [medium] yield in singleton class definitions in methods is now a SyntaxError
instead of a warning. yield in a class definition outside of a method
is now a SyntaxError instead of a LocalJumpError. [Feature #15575]
@Strech [medium] When a class variable is overtaken by the same definition in an
ancestor class/module, a RuntimeError is now raised (previously,
it only issued a warning in verbose mode).
[Bug #14541]
[medium] @bjfish Accessing a class variable from the toplevel scope is now a RuntimeError.
[Bug #14541]
[easy] Assigning to a numbered parameter is now a SyntaxError instead of
a warning.
Command line options
--help
optionRUBY_PAGER
orPAGER
is present and hasa non-empty value, and the standard input and output are tty, the
--help
option shows the help message via the pager designated by the value.
[Feature #16754]
--backtrace-limit
option--backtrace-limit
option limits the maximum length of a backtrace.[Feature #8661]
Core classes updates
Outstanding ones only.
Array
[easy, ruby-only] @Strech [Ruby 3.0 support] Add support for Array subclass methods to return Array #2510 The following methods now return Array instances instead of
subclass instances when called on subclass instances:
[Bug #6087]
[medium, ruby-only with one call from java] @ccocchi [Ruby 3.0 support] Array#slice with arithmetic sequence #2526 Can be sliced with Enumerator::ArithmeticSequence
Binding
"(eval)"
for
__FILE__
and1
for__LINE__
in the evaluated code.[Bug #4352] [Bug #17419]
ConditionVariable
block
/unblock
schedulerhooks in a non-blocking context. [Feature #16786]
Dir
accept the
sort:
keyword option. [Feature #8709]ENV
[easy, pure ruby] ENV.except has been added, which returns a hash excluding the
given keys and their values. [Feature #15822]
Windows: Read ENV names and values as UTF-8 encoded Strings
[Feature #12650]
Encoding
[hard, jcodings] Added new encoding IBM720. [Feature #16233]
Changed default for Encoding.default_external to UTF-8 on Windows
[Feature #16604]
Fiber
[easy] @aardvark179 Fiber.new(blocking: true/false) allows you to create non-blocking
execution contexts. [Feature #16786]
[easy] @aardvark179 Fiber#blocking? tells whether the fiber is non-blocking. [Feature #16786]
[medium] @eregon Fiber#backtrace and Fiber#backtrace_locations provide per-fiber backtrace.
[Feature #16815]
@bjfish The limitation of Fiber#transfer is relaxed. [Bug #17221]
GC
when compaction runs. Setting
auto_compact=
totrue
will causecompaction to occur during major collections. At the moment,
compaction adds significant overhead to major collections, so please
test first! [Feature #17176]
Hash
[easy, pure ruby] @ccocchi Allow Hash#transform_keys to take a hash argument #2464 Hash#transform_keys and Hash#transform_keys! now accept a hash that maps
keys to new keys. [Feature #16274]
[easy, pure ruby] @wildmaples Implement Hash#except #2463 Hash#except has been added, which returns a hash excluding the
given keys and their values. [Feature #15822]
IO
[hard, need to check side effects] @aardvark179 IO#nonblock? now defaults to
true
. [Feature #16786]related methods (e.g. IO#puts, IO#gets) may invoke the scheduler hook
#io_wait(io, events, timeout)
in a non-blocking execution context.[Feature #16786]
Kernel
[medium, java] @andrykonchin Kernel#clone when called with the
freeze: false
keyword will call#initialize_clone
with thefreeze: false
keyword.[Bug #14266]
[medium, java] @andrykonchin Kernel#clone when called with the
freeze: true
keyword will call#initialize_clone
with thefreeze: true
keyword, and willreturn a frozen copy even if the receiver is unfrozen.
[Feature #16175]
@aardvark179 [easy, might be already the case] Kernel#eval when called with two arguments will use
"(eval)"
for
__FILE__
and1
for__LINE__
in the evaluated code.[Bug #4352]
[easy] Kernel#lambda now warns if called without a literal block.
[Feature #15973]
#kernel_sleep(...)
in anon-blocking execution context. [Feature #16786]
Module
[hard] @bjfish Module#include and Module#prepend now affect classes and modules
that have already included or prepended the receiver, mirroring the
behavior if the arguments were included in the receiver before
the other modules and classes included or prepended the receiver.
[Feature #9573]
@bjfish [medium, java] Module#public, Module#protected, Module#private, Module#public_class_method,
Module#private_class_method, toplevel "private" and "public" methods
now accept single array argument with a list of method names. [Feature #17314]
[medium, java] @gogainda Module#attr_* methods now return an array of method names #2498 Module#attr_accessor, Module#attr_reader, Module#attr_writer and Module#attr
methods now return an array of defined method names as symbols.
[Feature #17314]
[easy] @gogainda Module#alias_method now returns the defined alias as a symbol.
[Feature #17314]
Mutex
Mutex
is now acquired per-Fiber
instead of per-Thread
. This changeshould be compatible for essentially all usages and avoids blocking when
using a scheduler. [Feature #16792]
Proc
separate Proc instances if the procs were created from the same block.
[Feature #14267]
Queue / SizedQueue
block
/unblock
scheduler hooks in a non-blocking context.[Feature #16786]
Ractor
more details.
Random
[easy, pure ruby] @eregon
Random::DEFAULT
now refers to theRandom
class instead of being aRandom
instance,so it can work with
Ractor
.[Feature #17322]
[easy, pure ruby] @eregon
Random::DEFAULT
is deprecated since its value is now confusing and it is no longer global,use
Kernel.rand
/Random.rand
directly, or create aRandom
instance withRandom.new
instead.[Feature #17351]
String
@bjfish [easy] The following methods now return or yield String instances
instead of subclass instances when called on subclass instances:
[Bug #10845]
@bjfish [easy] The following methods now return or yield String instances
instead of subclass instances when called on subclass instances:
[Bug #10845]
Symbol
[might already be the case, easy] Symbol#to_proc now returns a lambda Proc. [Feature #16260]
@bjfish [easy, java] Symbol#name has been added, which returns the name of the symbol
if it is named. The returned string is frozen. [Feature #16150]
Fiber
Fiber.scheduler for accessing the current scheduler. See
rdoc-ref:fiber.md for more details about what operations are supported and
how to implement the scheduler hooks. [Feature #16786]
@aardvark179 [hard] Fiber.blocking? tells whether the current execution context is
blocking. [Feature #16786]
block
/unblock
in anon-blocking execution context. [Feature #16786]
Thread
default deadlock detection, allowing the use of signal handlers to
break deadlock. [Bug #13768]
Warning
[Feature #17122]
Stdlib updates
Set
SortedSet has been removed for dependency and performance reasons.
Set#join is added as a shorthand for
.to_a.join
.Set#<=> is added.
Socket
Compatibility issues
Excluding feature bug fixes.
[done for Regexp, todo for Range, medium] @tomstuart @MattAlp Regexp literals and all Range objects are frozen. [Feature #8948] [Feature #16377] [Feature #15504]
Embed Range literals in the AST Embed Range literals in the AST #2622
[medium] @bjfish EXPERIMENTAL: Hash#each consistently yields a 2-element array. [Bug #12706]
{ a: 1 }.each(&->(k, v) { })
raises an ArgumentErrordue to lambda's arity check.
[medium] When writing to STDOUT redirected to a closed pipe, no broken pipe #2532 When writing to STDOUT redirected to a closed pipe, no broken pipe
error message will be shown now. [Feature #14413]
[easy, pure ruby]
TRUE
/FALSE
/NIL
constants are no longer defined.@bjfish [easy, pure ruby] Integer#zero? overrides Numeric#zero? for optimization. [Misc #16961]
@bjfish [medium] Enumerable#grep and Enumerable#grep_v when passed a Regexp and no block no longer modify
Regexp.last_match. [Bug #17030]
Requiring 'open-uri' no longer redefines
Kernel#open
.Call
URI.open
directly oruse URI#open
instead. [Misc #15893]SortedSet has been removed for dependency and performance reasons.
Stdlib compatibility issues
@eregon Default gems
The following libraries are promoted to default gems from stdlib.
The following extensions are promoted to default gems from stdlib.
@eregon Bundled gems
If you are interested in maintaining them, please comment on
your plan to https://github.com/ruby/xmlrpc
or https://github.com/ruby/net-telnet.
@eregon SDBM has been removed from the Ruby standard library. [Bug #8446]
@eregon WEBrick has been removed from the Ruby standard library. [Feature #17303]
C API updates
@eregon C API functions related to
$SAFE
have been removed.[Feature #16131]
@eregon C API header file
ruby/ruby.h
was split. [GH-2991]This should have no impact on extension libraries,
but users might experience slow compilations.
@eregon Memory view interface [EXPERIMENTAL]
such as a numeric array or a bitmap image, between extension libraries.
The extension libraries can share also the metadata of the memory area
that consists of the shape, the element format, and so on.
Using these kinds of metadata, the extension libraries can share even
a multidimensional array appropriately.
This feature is designed by referring to Python's buffer protocol.
[Feature #13767] [Feature #14722]
[will add later since experimental & unstable in CRuby 3.0] Ractor related C APIs are introduced (experimental) in "include/ruby/ractor.h".
@eregon
rb_keyword_given_p()
was added to find if kwargs were passed from Ruby to C.Implementation improvements
already the case New method cache mechanism for Ractor. [Feature #16614]
in parallel and synchronization is needed even for method caches. However,
such synchronization can be overhead so introducing new inline method cache
mechanisms, (1) Disposable inline method cache (2) per-Class method cache
and (3) new invalidation mechanism. (1) can avoid per-method call
synchronization because it only uses atomic operations.
See the ticket for more details.
@eregon The number of hashes allocated when using a keyword splat in
a method call has been reduced to a maximum of 1, and passing
a keyword splat to a method that accepts specific keywords
does not allocate a hash.
[already the case, all
super
are optimized]super
is optimized when the same type of method is called in the previous callif it's not refinements or an attr reader or writer.
Miscellaneous changes
@eregon Methods using
ruby2_keywords
will no longer keep empty keywordsplats, those are now removed just as they are for methods not
using
ruby2_keywords
.[already the case] When an exception is caught in the default handler, the error
message and backtrace are printed in order from the innermost.
[Feature #8661]
[easy, cleanup] Accessing an uninitialized instance variable no longer emits a
warning in verbose mode. [Feature #17055]
The text was updated successfully, but these errors were encountered: