Prevent Prompt on Reload

[eric-hemasystems]

I would like to prevent Textadept from prompting me when the file changes on the filesystem. I would rather it just reload the file automatically.

I may have 4-6 buffers open at any given time and if I switch branches I get prompt after prompt asking me if I want to reload various files. I would rather is just assume if the file on disk changes I want the latest changes to that file visible in Textadept without prompting me.

In the documentation for the FILE_CHANGED event the API documentation says:

When connecting to this event, connect with an index of 1 in order to override the default prompt to reload the file.

This sounds a bit like what I'm looking for although it's talking more about overriding the message not really stopping the prompt. Just in case I gave it a whirl and tried unconditionally reloading after installing the hook:

events.connect(events.FILE_CHANGED, function() buffer:reload() end, 1)

No luck. :(. Next I did a bit of searching in the source code to see if I could figure out how to do it. I think I found the relevant code at:

textadept/core/file_io.lua

Lines 299 to 308 in 96f58f1

	-- Prompts the user to reload the current file if it has been externally modified.
	events.connect(events.FILE_CHANGED, function(filename)
	local button = ui.dialogs.message{
	title = _L['Reload modified file?'],
	text = string.format('"%s"\n%s', filename:iconv('UTF-8', _CHARSET),
	_L['has been modified. Reload it?']), icon = 'dialog-question', button1 = _L['Yes'],
	button2 = _L['No']
	}
	if button == 1 then buffer:reload() end
	end)

The code seems to be unconditionally prompting. I can install an event handler that cancels further handlers. Something like:

events.connect(events.FILE_CHANGED, function()
  buffer:reload()
  return false
end, 1)

This works but it feels heavy handed as it cancels all other event handlers attached to that event. I searched the code base for any other handlers and I think it is the only one but perhaps other modules might use that event or something.

Ideally I could use events.disconnect but since it's an anonymous function I don't have any way to get a reference to that function.

Is there any other (probably obvious) way to do this?

[orbitalquark]

No, that is the way to do it. For `events.FILE_CHANGED`, there are no other handlers, so there is no risk of overriding the default behavior.