Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch extra key settings #23

Open
c0c0n3 opened this issue Jan 27, 2020 · 1 comment
Open

Ditch extra key settings #23

c0c0n3 opened this issue Jan 27, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@c0c0n3
Copy link
Member

c0c0n3 commented Jan 27, 2020

We should get rid of the following params in the adapter config:

  • idsa_public_key
  • idsa_private_key

In fact, idsa_public_key is the pub key the adapter uses to validate tokens in incoming requests from another IDS connector whereas idsa_private_key is the corresponding private key. Since we expect incoming requests will contain an ID token the client connector got from the same DAPS server we use to get out ID token, then:

idsa_public_key = daps.server_certificate
@c0c0n3 c0c0n3 added the bug Something isn't working label Jan 27, 2020
@c0c0n3 c0c0n3 added this to the End February Release milestone Jan 27, 2020
@c0c0n3
Copy link
Member Author

c0c0n3 commented Jan 27, 2020

Probably best to tackle this issue alongside #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant