-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Docker image #735
Comments
So we should really move away from Python 3.8, but that's too much effort. An avenue we can explore is to upgrade But I think that was a useless thing to do anyway. In fact, the same PR installs the latest which means at the moment we get version and pin |
Notice that the upgrade path isn't straightforward. The problem is that, like us, other Pythonistas out there also have dependency hell issues. Here's an example. If you delete the Pipenv lock file and try regenerating it (or just upgrade deps) you'll see that all the QL tests will break. One of the errors is this
(see pallets/markupsafe#282) Why is that happening? Well, our deps declaration in the Pipfile lead to the following dependency tree---just showing the paths that contain the
With these dependency constraints, the dependency solver can pick any version of the
But in actual fact, Anyways, what can we do about it? One option would be to add an explicit dependency on |
Describe the bug
Can't build the Docker image at the moment. The step where we install the Python deps fails. Since we don't pin every dep, most likely we've bumped in another instance of self-inflicted dependency hell.
To Reproduce
See e.g. PR #730's build log
Or run
docker build -t orchestracities/quantumleap .
from the root dir yourself.Expected behavior
You should be able to build the Docker image.
Environment
Additional context
This is just another installment of the neverending dependency hell saga, see e.g. #273.
The text was updated successfully, but these errors were encountered: