Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Read the Docs deprecation #771

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Conversation

pooja1pathak
Copy link
Collaborator

Proposed changes

Fix for #731

Types of changes

What types of changes does your code introduce to the project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the existing tests locally (not just those related to my feature) and there are no errors
  • After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
  • I have updated the RELEASE NOTES
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

github-actions bot commented Aug 27, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

Copy link
Member

@c0c0n3 c0c0n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooja1pathak that's great, did you check the docs build fine and the rendered site works as expected?

@pooja1pathak
Copy link
Collaborator Author

pooja1pathak commented Aug 28, 2024

@c0c0n3 I have checked, the build failed for mkdocs version 1.5.1 and without os version. I have updated the PR and build was successful for my branch:
image

@c0c0n3
Copy link
Member

c0c0n3 commented Aug 29, 2024

@pooja1pathak cool bananas, I'm merging this PR, then we should check if the ReadTheDocs badge on this repo's readme gets green...

@c0c0n3 c0c0n3 merged commit 163f69d into orchestracities:master Aug 29, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants