350 KiB limit excludes CPython repo's 9 large source files

[JDLH]

Select Topic Area

Product Feedback

Body

Code search has a published limitation that "files over 350 KiB are excluded". I would like to report some more cases of important source files from important repos which are poorly served by this limit. See also #37569, #138767, #18624, #122801, #63353, #39043, #10990.

The official repo of the reference Python interpreter CPython includes 9 source files which exceed this limit:

find . \( -iname '*.c' -or -iname '*.h' -or -iname '*.py' \) \
> -size +350k -ls | sort -k 7 --reverse   
... 1478859 ... ./Parser/parser.c
... 1315746 ... ./Modules/unicodename_db.h
...  823119 ... ./Lib/pydoc_data/topics.py
...  601387 ... ./Python/Python-ast.c
...  572370 ... ./Modules/unicodedata_db.h
...  487848 ... ./Modules/posixmodule.c
...  471722 ... ./Objects/unicodeobject.c
...  376291 ... ./Lib/test/test_typing.py
...  365550 ... ./Modules/cjkcodecs/mappings_jp.h

(This output is just the file size in bytes and the relative file path; I elided the other columns since they are not relevant.)

There are a total of 65 files which exceed this limit in a clean CPython repo (with no build artifacts):

% make clean
% find . \( \( -name .git -or -iname '*.o' -or -iname '*.a' -or -iname '*.exe' -or -iname '*.pickle' \                                                                                   
> -or -iname '*.whl' \) -prune \) -or   -size +350k -ls | sort -k 7 --reverse | wc -l
      65
% find . \( \( -name .git -or -iname '*.o' -or -iname '*.a' -or -iname '*.exe' -or -iname '*.pickle' \                                                                                   
> -or -iname '*.whl' \) -prune \) -or   -size +350k -ls | sort -k 7 --reverse | head -10
... 4289021 ... ./Misc/svnmap.txt
... 2602300 ... ./Doc/build/doctrees/whatsnew/changelog.doctree
... 2435471 ... ./Doc/data/python3.13.abi
... 1478859 ... ./Parser/parser.c
... 1355294 ... ./Misc/HISTORY
... 1339803 ... ./Doc/build/html/genindex-all.html
... 1315746 ... ./Modules/unicodename_db.h
... 1285615 ... ./Doc/build/html/searchindex.js
... 1145918 ... ./config.log
... 1082095 ... ./Doc/build/doctrees/library/os.doctree

I am taking the time to give this feedback because I was just bitten by this limit. I was searching the CPython repo via GitHub, looking for the definition of a function PyUnicode_DecodeUTF16Stateful. GitHub code search did not find it for me. I had to download the code to my local machine and search with my local code editor instead.

It would be nice if GitHub code search could have come through for me in this situation.

[Edited to include two .py source files in the first listing. Accordingly, changed "7" to "9" in the topic title and boy. Also added a missing . to the relative paths in both listings.]

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[look]

Thank you for the detailed feedback @JDLH. We know this limit can be frustrating especially in cases like this when it causes you to not trust the search results. The limit we have in place is to protect the availability of the system for everyone, so we have to be careful about changing it. That said, I will share this feedback with the rest of the team.