Remarks for deepin English translators

[raspin0]

I don't know exactly where to ask this, so please pass this information to translators if possible.

When there is a countable noun, please create a pluralized string instead of trying to handle both cases in one string.
Example - hour(s) --> hour | hours

[BLumia]

IMO it should be changed from the source code first since the original text may not using the correct way to handle plurals. Could you list some places that have this issue so I can check if it needs to be modified from the source code? Thanks!

[raspin0]

There are a lot of occurrences of this issue. I need those strings in pluralized form because for example:
In Polish Notification = Powiadomienie

1 Powiadomienie -> 2-4 Powiadomienia -> 5-999 Powiadomień

[BLumia]

Thanks, I'll check if they need to be fixed later:)

[BLumia]

Can confirm this need to be fixed, the following may contain some false positive but should be able to confirm issue exists:

$ rg -tcpp '\(s\)*."'
deepin-download/src/mainwindow.cpp
1580:            SetBottomStatusText( tr("%1 task is processing,").arg( acount ) +" " + tr("total %1 task(s)").arg( zcount )  );
1584:            SetBottomStatusText( tr("%1 tasks are processing,").arg( acount ) +" " + tr("total %1 task(s)").arg( zcount ) );
1591:        SetBottomStatusText( tr("total %1 task(s)").arg( zcount ) );
1658:            SetBottomStatusText( tr("%1 task is processing,").arg( acount ) +" " + tr("total %1 task(s)").arg( zcount )  );
1662:            SetBottomStatusText( tr("%1 tasks are processing,").arg( acount ) +" " + tr("total %1 task(s)").arg( zcount ) );
1669:        SetBottomStatusText( tr("total %1 task(s)").arg( zcount ) );

deepin-system-monitor/src/system/cpu_set.cpp
256:    return d->m_info.value("CPU(s)").toInt();
261:    return d->m_info.value("Socket(s)").toInt();

deepin-font-manager/deepin-font-manager/views/dfdeletedialog.cpp
145:    messageTitle->setText(DApplication::translate("DeleteConfirmDailog", "Are you sure you want to delete %1 font(s)?").arg(m_deleteCnt));

dde-calendar/calendar-client/src/dialog/scheduledlg.cpp
777:    m_endrepeattimesLabel = new QLabel(tr("time(s)"));

dde-file-manager/src/dde-file-manager-lib/dialogs/dialogmanager.cpp
1229:        titleLabel->setText(tr("Sorry, you don't have permission to operate the following %1 file/folder(s)!").arg(QString::number(urls.count())));

dde-file-manager/src/dde-file-manager-lib/dialogs/dmultifilepropertydialog.cpp
169:    coupleLabelContent.emplace_back(QObject::tr("Number of files"), QObject::tr("%1 file(s), %2 folder(s)")

deepin-devicemanager/deepin-devicemanager/src/DeviceManager/DeviceCpu.cpp
109:                 .arg(tr("Core(s)")) \

deepin-compressor/src/source/tree/datamodel.cpp
70:        strSize = QString::number(entry.qSize) + " " + tr("item(s)");

deepin-compressor/src/source/tree/uncompressview.cpp
685:        int iResult = dialog.showDialog(tr("Do you want to delete the selected file(s)?"), tr("Cancel", "button"), DDialog::ButtonNormal, tr("Confirm", "button"), DDialog::ButtonRecommend);

deepin-riscv/dde-file-manager-5.5.3/src/dde-file-manager-lib/dialogs/dialogmanager.cpp
1229:        titleLabel->setText(tr("Sorry, you don't have permission to operate the following %1 file/folder(s)!").arg(QString::number(urls.count())));

deepin-riscv/dde-file-manager-5.5.3/src/dde-file-manager-lib/dialogs/dmultifilepropertydialog.cpp
169:    coupleLabelContent.emplace_back(QObject::tr("Number of files"), QObject::tr("%1 file(s), %2 folder(s)")

deepin-compressor/tests/UnitTest/src/source/tree/ut_datamodel.cpp
99:    ASSERT_EQ(m_tester->data(index, Qt::DisplayRole), QString::number(m_tester->m_listEntry[1].qSize) + " " + QObject::tr("item(s)"));

Will try to work on fixes for those projects. For people who are reading this, please also feel free to send us Pull Requests if you like and we'll happy to help you get it merged.

Thanks!