You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to share the review policy of ThorVG. ThorVG has been developed by a small number of maintainers relative to its features, and we follow a relatively rapid development and deployment policy. According to this policy, unless there are any exceptions, we conduct micro version updates every Friday and quickly address the issues that can be resolved within the week. So please review the PRs if those must be included in a next mirco version up release.
As specified in the CODEOWNER file, we designate a main maintainer for each module and expect them to diligently perform their roles as official reviewers. Basically, PRs that involve modifications to a specific module must be thoroughly reviewed and approved by the module's reviewer, and the PR can only be merged when at least one designated module reviewer and total two ThorVG official reviewers, including myself, have approved it. If a PR is neglected without review or cannot receive the approval of two or more reviewers due to the absence of the responsible maintainer for the module, I, as the project lead, will take appropriate measures. If you intend to review but are unable to proceed with the review in 2 weeks due to personal reasons, please leave a comment on the PR indicating such, and we will delay the PR review process accordingly.
Additionally, if committers, reviewers, or maintainers do not participate in the review process or any kind of contribution for more than six months, we will consider this as an indication of their disinterest in continuing with the project and will withdraw their committer, reviewer or maintainer permissions.
If there are any concerns, objections, or questions regarding the policy addressed here, let's freely discuss them.
Thank you always for your dedicated collaboration and sincere efforts.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hello, thorvg maintainers: @JSUYA @mgrudzinska @RuiwenTang @SergeyLebedkin @tinyjin @ol-of
I would like to share the review policy of ThorVG. ThorVG has been developed by a small number of maintainers relative to its features, and we follow a relatively rapid development and deployment policy. According to this policy, unless there are any exceptions, we conduct micro version updates every Friday and quickly address the issues that can be resolved within the week. So please review the PRs if those must be included in a next mirco version up release.
As specified in the CODEOWNER file, we designate a main maintainer for each module and expect them to diligently perform their roles as official reviewers. Basically, PRs that involve modifications to a specific module must be thoroughly reviewed and approved by the module's reviewer, and the PR can only be merged when at least one designated module reviewer and total two ThorVG official reviewers, including myself, have approved it. If a PR is neglected without review or cannot receive the approval of two or more reviewers due to the absence of the responsible maintainer for the module, I, as the project lead, will take appropriate measures. If you intend to review but are unable to proceed with the review in 2 weeks due to personal reasons, please leave a comment on the PR indicating such, and we will delay the PR review process accordingly.
Additionally, if committers, reviewers, or maintainers do not participate in the review process or any kind of contribution for more than six months, we will consider this as an indication of their disinterest in continuing with the project and will withdraw their committer, reviewer or maintainer permissions.
If there are any concerns, objections, or questions regarding the policy addressed here, let's freely discuss them.
Thank you always for your dedicated collaboration and sincere efforts.
Best Regards,
Hermet
Beta Was this translation helpful? Give feedback.
All reactions