Default vuepress theme's HomePage broken by adding seo2 plugin

[narumi147]

The default vuepress theme provide a home page with hero image, text and features intro when home: true is set in frontmatter.

After I introduce the seo2 plugin, its dependency vuepress-shared plugin change the home page, the home page becomes a usual page with sidebar and original hero image, text, features intro are useless in this plugin's home setting.

I only want seo function here, is there any solution to disable the plugin's home theme?

[Mister-Hope]

I will have a look later. SEO do not have any client side, why would it break your layout?

Did it remove the original frontmatter? Any detailed information about how this plugin is effecting your client side is welcomed.

[narumi147]

---
home: true
title: Home
heroImage: /chaldea.png
heroText: Chaldea
actions:
  - text: Installation
    link: /installation.html
    type: primary
  - text: User Manual
    link: /introduction.html
    type: secondary
features:
  - title: Feature 1
    details: description 1.
  - title: Feature 1
    details: description 1.
  - title: Feature 1
    details: description 1.
  - title: Feature 1
    details: description 1.
    
footer: MIT Licensed | Copyright © 2021-present narumi
---
This is README.md

  plugins: [
    ['@vuepress/plugin-search'],
    ["vuepress-plugin-seo2"],
  ]

All frontmatter are removed, didn't render in html, I guess this plugin's default theme (in shared) has intercepted the home keyword.

[Mister-Hope]

Go it, I will checkout today.

[narumi147]

Another problem here.

While only integrating sitemap plugin, building failed because of themeConfig is undefined when reading themeConfig.git. Although I don't know why need git plugin here? So inside plugins, it's better to check themeConfig exists or not before reading.

[narumi147]

for sitemap, i was using the legacy version @mr-hope/vuepress-plugin-sitemap, after migrating to vuepress-plugin-sitemap2, it works, though @next version cannot be used because it need vite.

[Mister-Hope]

That should be the actual problem, v1has different api with v2.

For plugin git, it's reading git database to get the creation time.

[Mister-Hope]

And for vite, my plugin do not care what bundler you are using, should be working on both bundler, so could you explain why you think that "it need vite"

[narumi147]

for vuepress-plugin-sitemap2: 2.0.0-alpha.0 works, but ^2.0.0-alpha.5 failed

Error: Cannot find module 'vite'
Require stack:
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/vuepress-plugin-sitemap2/node_modules/@mr-hope/vuepress-shared/node/index.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/vuepress-plugin-sitemap2/node/index.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/core/lib/app/resolvePluginModule.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/core/lib/app/resolvePlugin.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/core/lib/app/appUse.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/core/lib/app/index.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/core/lib/index.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/cli/lib/commands/build/createBuild.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/cli/lib/commands/build/index.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/cli/lib/commands/index.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/@vuepress/cli/lib/index.js
- /Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/vuepress/bin/vuepress.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:94:18)
    at Object.<anonymous> (/Users/narumi/Projects/chaldea-project/chaldea-docs/node_modules/vuepress-plugin-sitemap2/node_modules/@mr-hope/vuepress-shared/node/index.js:1:75)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
error Command failed with exit code 1.

[narumi147]

Although we can build with webpack or vite, but if I only want to use webpack, and didn't add vite into package.json, the error will raise.
So I need to add vite too to ensure the build works even I don't need it.

[narumi147]

Any progress on why vuepress' default Home is broken?

[Mister-Hope]

Yes, see a recent discussion in VuePress (by me)

There are some design issues.

[narumi147]

I see, is there any temp trick to bypass it?

Just link here to remind me.

• [Design issues] Edit frontmatter could be complicated vuepress/core#521

[Mister-Hope]

Yes, I am actually merging the default frontmatter in "a usual way", but it's not working as expected, some editions may needed at @vuepress/core to let this feature work well. I personally don't think I need to make some "hack" here, as other plugins may possibly break frontmatter:

vuepress-theme-hope/packages/seo2/src/node/index.ts

Line 36 in bfc530f

return { frontmatter: { ...page.frontmatter, head } };

Actually I can not reproduct the issue you are reporing in my workspace, so I guess your are hinting the situation I mentioned.

[narumi147]

Tried on master branch, still broken. Since I know nothing about node/js, maybe just wait for official fix. 😂
But it's strange why you cannot reproduce, what if test on the following repo?
https://github.com/chaldea-center/chaldea-docs

[Mister-Hope]

beta 29 released and fix this issue by changing api(BREAKING CHANGES), Once I build a compatblable version for it, it will be fine.