Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should this null-check be here? #111

Closed
ZainlessBrombie opened this issue Nov 4, 2020 · 2 comments
Closed

Should this null-check be here? #111

ZainlessBrombie opened this issue Nov 4, 2020 · 2 comments

Comments

@ZainlessBrombie
Copy link

https://github.com/jkuhnert/ognl/blob/99d53aebe43436e90351ee64c99ec1eb7b675204/src/main/java/ognl/OgnlRuntime.java#L1951

I'm passing in some nulls in my varargs, which is legal. However they are being filtered out here. Is this intentional? This does not seem correct to me.
A single null would be ambiguous because it could be meant to be the array OR the array content, but multiple nulls are always interpreted as an array in java varargs.
@lukaszlenart
Copy link
Collaborator

Hm... looks like you are right

@lukaszlenart
Copy link
Collaborator

It's ok, see #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukaszlenart @ZainlessBrombie