Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing annotations for deployments in maester charts #728

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: added missing annotations for deployments in maester charts #728

wants to merge 2 commits into from

Conversation

rrmistry
Copy link

@rrmistry rrmistry commented Jan 8, 2025

Related Issue or Design Document

Fixes: #727

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rrmistry rrmistry changed the title Added missing annotations for deployments in maester charts fix: Added missing annotations for deployments in maester charts Jan 8, 2025
@rrmistry rrmistry changed the title fix: Added missing annotations for deployments in maester charts fix: added missing annotations for deployments in maester charts Jan 8, 2025
@rrmistry rrmistry marked this pull request as ready for review January 8, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demonsthere Demonsthere Awaiting requested review from Demonsthere Demonsthere is a code owner

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix deployment annotations for maester charts
2 participants
@rrmistry @CLAassistant