Considering All properties of Objects?

[kallyas]

https://github.com/OSCA-Kampala-Chapter/autobot/blob/226a050a6e8a9b206e51fd6a705f74c649a566c9/autobot/telegram/parser.py#L18

When creating parser methods, do we consider all properties of the objects? @ht-thomas

[TobiasHT5]

@kallyas the parsing action is directed by the key that is passed to the parsing method. There are many keys that map to the same parsing method. For example, all those keys in that case statement map to the message parsing method which constructs a message object.

You should also know that parsing methods are responsible for parsing every object that appears in the module they are parsing. For example, _parse_message is responsible for parsing the message object, MessageID object and others found in the message.py module

[kallyas]

For example, for the Game object @ht-thomas

 def _parse_game (self,key:str,val:dict) -> Game:
        game_obj = Game()
        for k,v in val.items():
            match k:
                case "photo":
                    pht = self._parse_photosize(k,v)
                    setattr(game_obj,k,pht)
                case "animation":
                    anim = self._parse_animation(k,v)
                    setattr(game_obj,k,anim)
                case _:
                    setattr(game_obj,k,v)
        return game_obj

[TobiasHT5]

Now here _parse_game would be responsible for parsing Game and GameHighScore. So you'll have to check if key maps to a Game object or GameHighScore object. There are many keys that could be parsing to the Game object, so you have to categorize them in a case statement or if statement. But generally, your code is 95% what we're doing. It's just that we'll need to twick it to make it right.

[TobiasHT5]

@kallyas to take you example, we'd do something like

def _parse_game (self,key:str,val:dict) -> Game|GameHighScore:
    game_obj = None
    if (key == "game"):
        game_obj = Game()
        for k,v in val.items():
            match k:
                case "photo":
                    pht = self._parse_photosize(k,v)
                    setattr(game_obj,k,pht)

And you'd continue along those lines

[kallyas]

Got it