From 3f6ac844dd3293837e4eed9550858cd0612901b2 Mon Sep 17 00:00:00 2001 From: Jonas Lindevall Date: Thu, 23 Nov 2023 14:45:26 +0100 Subject: [PATCH 1/3] change to correct padding and remove padding from buttons inside card__action --- src/components/cards/portrait_card/portrait_card.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/cards/portrait_card/portrait_card.scss b/src/components/cards/portrait_card/portrait_card.scss index 3d52e69ab..84b8d9079 100644 --- a/src/components/cards/portrait_card/portrait_card.scss +++ b/src/components/cards/portrait_card/portrait_card.scss @@ -35,8 +35,12 @@ $ods-portrait-card-image-height-large: 290px; } &__actions { - @extend %ods-padding-horizontal-3, %ods-padding-bottom-4, %ods-padding-top-0-breakpoint-medium, %ods-padding-horizontal-4-breakpoint-medium, %ods-padding-bottom-8-breakpoint-medium, %ods-padding-top-0-breakpoint-large, %ods-padding-horizontal-8-breakpoint-large, %ods-padding-bottom-8-breakpoint-large; + @extend %ods-padding-horizontal-3, %ods-padding-bottom-4, %ods-padding-top-0-breakpoint-medium, %ods-padding-horizontal-4-breakpoint-medium, %ods-padding-bottom-8-breakpoint-medium, %ods-padding-top-0-breakpoint-large, %ods-padding-horizontal-4-breakpoint-large, %ods-padding-bottom-8-breakpoint-large; @extend %ods-color-bg-gray-light; + + & .ods-button { + padding: 0; + } } &__heading { From 9e6be7fc1e19e73a7d9716daa05c9f8f29791de8 Mon Sep 17 00:00:00 2001 From: Jonas Lindevall Date: Thu, 23 Nov 2023 15:05:03 +0100 Subject: [PATCH 2/3] changes to padding on all breakpoints --- src/components/cards/portrait_card/portrait_card.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/cards/portrait_card/portrait_card.scss b/src/components/cards/portrait_card/portrait_card.scss index 84b8d9079..61a7e5b97 100644 --- a/src/components/cards/portrait_card/portrait_card.scss +++ b/src/components/cards/portrait_card/portrait_card.scss @@ -35,7 +35,7 @@ $ods-portrait-card-image-height-large: 290px; } &__actions { - @extend %ods-padding-horizontal-3, %ods-padding-bottom-4, %ods-padding-top-0-breakpoint-medium, %ods-padding-horizontal-4-breakpoint-medium, %ods-padding-bottom-8-breakpoint-medium, %ods-padding-top-0-breakpoint-large, %ods-padding-horizontal-4-breakpoint-large, %ods-padding-bottom-8-breakpoint-large; + @extend %ods-padding-horizontal-5, %ods-padding-bottom-4, %ods-padding-top-0-breakpoint-medium, %ods-padding-horizontal-4-breakpoint-medium, %ods-padding-bottom-8-breakpoint-medium, %ods-padding-top-0-breakpoint-large, %ods-padding-horizontal-4-breakpoint-large, %ods-padding-bottom-8-breakpoint-large; @extend %ods-color-bg-gray-light; & .ods-button { @@ -75,7 +75,7 @@ $ods-portrait-card-image-height-large: 290px; &--xs { & .ods-portrait-card__content { - @extend %ods-padding-5, %ods-padding-4-breakpoint-medium, %ods-padding-5-breakpoint-large; + @extend %ods-padding-4, %ods-padding-4-breakpoint-medium, %ods-padding-4-breakpoint-large; } & .ods-portrait-card__heading { @@ -102,7 +102,7 @@ $ods-portrait-card-image-height-large: 290px; } & .ods-portrait-card__actions { - @extend %ods-padding-top-0-breakpoint-large, %ods-padding-horizontal-8-breakpoint-large, %ods-padding-bottom-4-breakpoint-large; + @extend %ods-padding-top-0-breakpoint-large, %ods-padding-horizontal-4-breakpoint-large, %ods-padding-bottom-4-breakpoint-large; } } From 248d19145ec1c9c53bd19c605597784162d0bb98 Mon Sep 17 00:00:00 2001 From: Jonas Lindevall Date: Thu, 23 Nov 2023 15:06:11 +0100 Subject: [PATCH 3/3] update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a77c62ac4..aef5f248e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Fixed spacing around links and buttons in portrait card on all breakpoints. - Fixed hardcoded references to use s3.dualstack for IPv6 support. - Prevent plus/minus icon to show in other variants than filter. @@ -40,7 +41,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Remove font styles from lists and update the list's clean variant padding. This fixes the lists styles in the Banner component. - ## [1.0.2] - 23.10.2023 ### Fixed