š fix(theme): typo & Cusdis darkāmode sync #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aron5055 is attempting to deploy a commit to the Osmium Team on Vercel. A member of the Team first needs to authorize it. |
alen420
changed the title
SilentDepth
reviewed
May 10, 2025
Collaborator
SilentDepth
left a comment
SilentDepth
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Just left a few comments.
| import { ReactCusdis } from 'react-cusdis' | ||
| import { useRouter } from 'next/router' | ||
| import { useConfig } from '@/contexts/config' | ||
| import { useTheme } from "@/contexts/theme"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| import { useTheme } from "@/contexts/theme"; | |
| import { useTheme } from '@/contexts/theme' |
| pageTitle: post.title, | ||
| pageUrl: link + router.asPath, | ||
| theme: appearance, | ||
| theme: scheme, |
Collaborator
There was a problem hiding this comment.
I see Cusdis does support an auto value. Wouldnāt it be better to use appearance here?
Author
There was a problem hiding this comment.
However, it doesn't work during actual deployment. I have no idea why, but passing 'auto' defaults to the light theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
āļøāÆProblem Description
The Cusdis comment widget doesnāt respect the siteās theme setting:
Initial render ā Cusdis always receives "auto" and falls back to its default colors, so it may mismatch the rest of the page.
Theme toggle ā When the user switches between lightāÆ/āÆdark, Cusdis doesnāt update and sometimes freezes (the iframe stays mounted with the old styles).
š§āÆWhat This Patch Does
Fetches the resolved scheme ('light'āÆorāÆ'dark') from useTheme() instead of passing the raw appearance config.
Adds a key={\cusdis-${scheme}
}prop, forcing React to remount the widget whenever the scheme changes. This refreshes the iframe and eliminates the freeze.