Skip to content

šŸ› fix(theme): typo & Cusdis darkā€‘mode sync #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weā€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

šŸ› fix(theme): typo & Cusdis darkā€‘mode sync #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2211ea
Fix typo in appearance property in ThemeProvider
May 6, 2025
f5cb5d2
šŸ› make Cusdis follow resolved light/dark scheme
May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions components/comments/cusdis.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
import { ReactCusdis } from 'react-cusdis'
import { useRouter } from 'next/router'
import { useConfig } from '@/contexts/config'
import { useTheme } from "@/contexts/theme";
Copy link
Collaborator

@SilentDepth SilentDepth May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { useTheme } from "@/contexts/theme";
import { useTheme } from '@/contexts/theme'


export default function Cusdis ({ config, post }) {
const router = useRouter()
const { link, lang, appearance } = useConfig()
const { link, lang } = useConfig()
const { scheme } = useTheme()

return (
<ReactCusdis
key={`cusdis-${scheme}`}
attrs={{
pageId: post.id,
pageTitle: post.title,
pageUrl: link + router.asPath,
theme: appearance,
theme: scheme,
Copy link
Collaborator

@SilentDepth SilentDepth May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Cusdis does support an auto value. Wouldnā€™t it be better to use appearance here?

Copy link
Author

@alen420 alen420 May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, it doesn't work during actual deployment. I have no idea why, but passing 'auto' defaults to the light theme.

...config,
}}
lang={resolveLang(lang)}
Expand Down
2 changes: 1 addition & 1 deletion contexts/theme.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const ThemeContext = createContext<Context>(undefined as any)
export function ThemeProvider ({ children }: BasicProps) {
const config = useConfig()

const [theme, setTheme] = useState<Theme>(config.appearance === 'auto' ? 'system' : config.appearnce)
const [theme, setTheme] = useState<Theme>(config.appearance === 'auto' ? 'system' : config.appearance)

const [prefersDark, setPrefersDark] = useState<boolean>()

Expand Down