Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malteser Hilfsdienst is brand or operator? #6909

Closed
LaoshuBaby opened this issue Aug 11, 2022 · 6 comments
Closed

Malteser Hilfsdienst is brand or operator? #6909

LaoshuBaby opened this issue Aug 11, 2022 · 6 comments

Comments

@LaoshuBaby
Copy link
Collaborator

Now when run npm run build it will give a warning:

⚠️   Warning - matchIndex errors:
----------------------------------------------------------------------
  `key/value/name` occurs multiple times in the match index.
  To resolve these, make sure the key/value/name does not appear in multiple trees
    (e.g. `amenity/post_office/ups` should not be both a "brand" and an "operator"
----------------------------------------------------------------------
Duplicate cache key "amenity/recycling/q1318397" in trees "operators" and "brands", check items: malteserhilfsdienst-6737d9
total 1

This is because malteserhilfsdienst-6737d9 in operators/amenity/recycling.json and malteserhilfdienst-f6fab4 in brands/amenity/recycling.json are same entity, they have the same wikidata.

Details are shown below:

"displayName": "Malteser Hilfsdienst",
"id": "malteserhilfsdienst-6737d9",
"locationSet": {"include": ["de"]},
"matchNames": ["malteser hilfsdienst e.v."],
"tags": {
"amenity": "recycling",
"operator": "Malteser Hilfsdienst",
"operator:short": "MHD",
"operator:wikidata": "Q1318397"
}

"displayName": "Malteser Hilfdienst",
"id": "malteserhilfdienst-f6fab4",
"locationSet": {"include": ["de"]},
"matchNames": [
"malteser",
"malteser hilfdienst e.v."
],
"tags": {
"amenity": "recycling",
"brand": "Malteser Hilfdienst",
"brand:wikidata": "Q1318397",
"recycling_type": "container"
}

Maybe we need a German mapper review this and select which one should be use, and select proper matchNames and tags.

@kmpoppe
Copy link

kmpoppe commented Aug 18, 2022

Currently discussing on https://t.me/OSM_de whether it's one or the other - or both.

Will come back to you :-)

@Outlet2048
Copy link
Collaborator

#2588

Local experts could be pinged

@Outlet2048
Copy link
Collaborator

Looks like the Telegram group has decided on "brand"
Operator can only be determined through survey

for later reference: https://t.me/OSM_de/81212

@kjonosm
Copy link
Collaborator

kjonosm commented Aug 18, 2022

I agree that brand should rather be used as the organisation as a whole is split into regional dioceses and further into smaller branches which usually operate services on the local level.

@bhousel
Copy link
Member

bhousel commented Aug 18, 2022

Just linking here to the comment I wrote last year that might help decide whether an item is more brand-like or operator-like:

#5625 (comment)
#5924 (comment)

LaoshuBaby added a commit that referenced this issue Sep 1, 2022
@LaoshuBaby
Copy link
Collaborator Author

Vermutlich. Dann wohl nur "brand"

So I merge this, and reserve the brand one in 4fd6a08

2 item's name have different so I follow de-wikipedia's entry name.

Thanks for German community's advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants