Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galito's takeaway=yes re-added by build script #9862

Open
AntiCompositeNumber opened this issue Aug 31, 2024 · 2 comments
Open

Galito's takeaway=yes re-added by build script #9862

AntiCompositeNumber opened this issue Aug 31, 2024 · 2 comments
Labels

Comments

@AntiCompositeNumber
Copy link
Collaborator

AntiCompositeNumber commented Aug 31, 2024

In dbca82f @arrival-spring removed takeaway=yes from Galito's as not all locations offer takeaway. However, it was re-added by npm run build from the collector data in 35d6cd0. How can this be prevented?

@arrival-spring
Copy link
Collaborator

This was based on adding it to ATP, alltheplaces/alltheplaces#10028, and noting that in the data from Galito's it did not say that takeaway was available at all locations. I guess this could be incomplete data on their part, as nowhere explicitly states they don't do takeaway.

Looking through the website I can't be sure wither way, and don't have first hand information beyond that.

@UKChris-osm
Copy link
Collaborator

This seems to be done by the build_index.js script itself, and this code would need to me amended or removed, or a flag added to the data file that can prevent an automatic tag being added (in a similar way to how preserveTags works).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants