Skip to content

Conversation

@cuatim
Copy link
Contributor

@cuatim cuatim commented Nov 26, 2025

closes #2634

identical to other colours, expect "rainbow" is also allowed
@Famlam
Copy link
Collaborator

Famlam commented Dec 3, 2025

You probably want to either add rainbow twice to the regex rule (if you want to allow rainbow;red whatever that means) or instead special-case it by adding [surface:colour!=rainbow] instead, at the end of the rule. My preference would be the latter.

Can you add way surface:colour=rainbow to the tests (assertNoMatch-rules) at the bottom?

@cuatim
Copy link
Contributor Author

cuatim commented Dec 4, 2025

instead special-case it by adding [surface:colour!=rainbow] instead, at the end of the rule. My preference would be the latter.

agreed. done.

Can you add way surface:colour=rainbow to the tests (assertNoMatch-rules) at the bottom?

added as well!

@frodrigo frodrigo merged commit 76d3116 into osmose-qa:dev Dec 6, 2025
3 checks passed
@frodrigo
Copy link
Contributor

frodrigo commented Dec 6, 2025

Thank you all.
Merged, but not deployed, yet.

@cuatim cuatim deleted the patch-1 branch December 6, 2025 20:32
@cuatim cuatim mentioned this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow colour rainbow?

3 participants