diff --git a/x/poolmanager/types/keys_test.go b/x/poolmanager/types/keys_test.go new file mode 100644 index 00000000000..07a68121a0a --- /dev/null +++ b/x/poolmanager/types/keys_test.go @@ -0,0 +1,36 @@ +package types_test + +import ( + "testing" + + "github.com/stretchr/testify/require" + + "github.com/osmosis-labs/osmosis/v19/x/poolmanager/types" +) + +func TestFormatDenomTradePairKey(t *testing.T) { + tests := map[string]struct { + denom0 string + denom1 string + expectedKey string + }{ + "happy path": { + denom0: "uosmo", + denom1: "uion", + expectedKey: "\x04|uion|uosmo", + }, + "reversed denoms get reordered": { + denom0: "uion", + denom1: "uosmo", + expectedKey: "\x04|uion|uosmo", + }, + } + + for name, tc := range tests { + t.Run(name, func(t *testing.T) { + formatDenomTradePairKey := types.FormatDenomTradePairKey(tc.denom0, tc.denom1) + stringFormatDenomTradePairKeyString := string(formatDenomTradePairKey) + require.Equal(t, tc.expectedKey, stringFormatDenomTradePairKeyString) + }) + } +} diff --git a/x/txfees/keeper/hooks.go b/x/txfees/keeper/hooks.go index 569c8a00df0..9ece448b99c 100644 --- a/x/txfees/keeper/hooks.go +++ b/x/txfees/keeper/hooks.go @@ -92,7 +92,6 @@ func (k Keeper) swapNonNativeFeeToDenom(ctx sdk.Context, denomToSwapTo string, f // Skip this denom and move on to the next one. continue } - } // Do the swap of this fee token denom to base denom.