Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags coming on top of Project names #79

Open
tabshaikh opened this issue Oct 20, 2018 · 7 comments
Open

Tags coming on top of Project names #79

tabshaikh opened this issue Oct 20, 2018 · 7 comments
Labels
waiting for feedback This issue is waiting for feedback from a maintainer

Comments

@tabshaikh
Copy link
Contributor

Tags are overwritting on top of project names:
tags
@alexdor Maybe we can limit the number of tags we display upto 5 or something, so that the interface remains clean

@alexdor
Copy link
Member

alexdor commented Oct 20, 2018

@bacharakis thoughts?

@tabshaikh
Copy link
Contributor Author

@alexdor we could add ... if the number of tags are greater than 5 lets say at the end to indicate there are more tags

@alexdor
Copy link
Member

alexdor commented Oct 20, 2018

Yeah it's a nice idea, but we need @bacharakis thoughts before we can proceed because it's a change at the designs

@tabshaikh
Copy link
Contributor Author

Okay sure @bacharakis waiting for your advice on this :)

CharlesHopman added a commit to CharlesHopman/fixme that referenced this issue Oct 21, 2018
@alexdor alexdor mentioned this issue Oct 21, 2018
@bacharakis
Copy link
Contributor

Sorry for the late reply!
This is a great idea @tabshaikh but I have some follow-up questions.
Would you like to limit the tags to 5 regardless the screen resolution? And if so, how would someone can see the rest of tags?

@tabshaikh
Copy link
Contributor Author

@bacharakis we will have a see more option in the box which will show all the tags if a user wishes to see them all

@himankpathak
Copy link
Contributor

how about we create a modal whenever a user clicks on the project. The modal will contain all the tags in the project and a short description of the project and from the modal itself, the user can be directed either to issues page or the GitHub repo or the modal can be closed.

alexdor pushed a commit that referenced this issue Oct 31, 2018
* This solves #79

* Align projects logo with the design

 Align the project page logos with the designs https://github.com/ossn/fixme/blob/master/screens/desktop/Mozilla_Fixme_Screen03_Projects.png

* Update projects.scss

* Update projects.scss
@alexdor alexdor added the waiting for feedback This issue is waiting for feedback from a maintainer label Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback This issue is waiting for feedback from a maintainer
Projects
None yet
Development

No branches or pull requests

4 participants