[memory][scs][tests] Don't allow to sc-connectors belonging to sc-elements types

Author: NikitaZotov

sc-memory/sc-memory/src/scs/scs_parser.cpp

@@ -479,23 +479,33 @@ void Parser::ProcessTriple(
 
     if (source.IsElementType() && (connector.GetType() == ScType::ConstPermPosArc))
     {
+      if (target.m_type.IsConnector())
+        SC_THROW_EXCEPTION(
+            utils::ExceptionParseError,
+            "Connector with type `" << std::string(target.m_type)
+                                    << "` can't belong to sc-element denoting type of sc-elements `" << source.GetIdtf()
+                                    << "`.");
+
       std::string const & sourceIdtf = source.GetIdtf();
       ScType const newType = target.m_type | scs::TypeResolver::GetKeynodeType(sourceIdtf);
 
       if (target.IsElementType() && !newType.CanExtendTo(ScType::ConstNodeClass))
         SC_THROW_EXCEPTION(
             utils::ExceptionParseError,
             "Can't extend type `" << std::string(target.m_type) << "` to type `" << std::string(newType)
-                                  << "` for element `" << target.GetIdtf() << "`, because element `" << target.GetIdtf()
-                                  << "` is element denoting type of sc-elements.");
+                                  << "` for sc-element `" << target.GetIdtf() << "`, because sc-element `" << target.GetIdtf()
+                                  << "` is sc-element denoting type of sc-elements.");
       else if (target.m_type.CanExtendTo(newType))
         target.m_type = newType;
       else
+      {
+        std::cout << newType << std::endl;
         SC_THROW_EXCEPTION(
             utils::ExceptionParseError,
             "Can't extend type `" << std::string(target.m_type) << "` to type `" << std::string(newType)
-                                  << "` for element `" << target.GetIdtf() << "`, because `" << std::string(newType) 
+                                  << "` for sc-element `" << target.GetIdtf() << "`, because `" << std::string(newType) 
                                   << "` is not subtype of `" << std::string(target.m_type) << "`.");
+      }
 
       // TODO(NikitaZotov): Unfortunately, parser collects all sc.s-elements, and only then forms sc.s-triples based on
       // the parsed sc.s-elements. Due to this, it is difficult to handle cases when it is necessary not to generate a

sc-memory/sc-memory/tests/sc-memory/units/scs-helper/test_scs_helper.cpp

@@ -350,6 +350,13 @@ TEST_F(SCsHelperTest, DISABLED_GenerateBySCs_ContourWithExplicitlySpecifiedEleme
   EXPECT_FALSE(helper.GenerateBySCsText(scsData));
 }
 
+TEST_F(SCsHelperTest, GenerateBySCs_ConnectorBelongsToElementType)
+{
+  SCsHelper helper(*m_ctx, std::make_shared<DummyFileInterface>());
+  std::string const scsData = "..contour = [* sc_node_tuple -> (sc_node_class => sc_node_tuple);; *];;";
+  EXPECT_FALSE(helper.GenerateBySCsText(scsData));
+}
+
 TEST_F(SCsHelperTest, GenerateBySCs_NotBaseArcBetweenElementTypesWithinStructure)
 {
   SCsHelper helper(*m_ctx, std::make_shared<DummyFileInterface>());