Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing path parameters with file extensions, etc. #88

Closed
makdad opened this issue Jul 20, 2020 · 1 comment
Closed

Comments

@makdad
Copy link
Contributor

makdad commented Jul 20, 2020

As I wrote in interagent/committee#261 - my path of fribble/{id}.json failed to match because the OpenAPI parser expected that path parameters be "by themselves" (e.g. fribble/{id} or fribble/{id}/details.json). The legacy API I am modeling is unfortunately not this way.

I am opening the issue again on this repository because the root fix is in the parser, not in Committee.

I've made progress on a pull request to address this issue, but unfortunately it breaks some other tests. I am still looking into this, but I wanted to create the issue here, as well as post a link to the PR, so that I could begin to receive some feedback from the maintainers.

My first attempt:
https://github.com/makdad/openapi_parser/pull/1/files

@makdad
Copy link
Contributor Author

makdad commented Aug 27, 2020

I think we can close this issue, as #90 was merged into 0.12.0, so I think this is "fixed as of 0.12.0"?

@ota42y ota42y closed this as completed Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants