refactor(parse_spec): massive reorganization #37
+1,104
−737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename errors * Factor out each validator
Some validators are stateful across rules (e.g., check_for_duplicate_names). Some are not. If validators are assumed to process a single rule, then to allow for stateful validators, validators must be objects. This imposes a more complex protocol for using validators. Instead, if we move the responsibility of processing all rules to each validator, then validators can be represented by a simple function that takes an iterable of rules, and returns a list of errors. So that's what this commit does. Now all lexvalidate validators are functions that each process all the rules and return a list of errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authors of this PR...
Playing around with the organization of parse_spec.