[Deposit Result] Should only display deposit tab when it's deposit period

[mitchellchou]

Expected result

Should only display the deposit tab when it's deposit period

[joyzoursky]

Should also hide this? As it is always empty, and the yellow line should not exist when there is no period.

[hochiw]

@mitchellchou
When entering the detail page, say /proposals/10

We show the votes panel by default (as it's controlled by the url param, /proposals/10/votes and /proposals/10/deposits, so when there's no url params we show votes by default.

While we can pass the proposalStatus to the detail page to change the default panel to deposit when it's in deposit period, we don't actually know the the proposal status when we enter /proposals/10 manually in the url bar.

In this case do we just use deposit as default? and shall we swap the position of the tabs if we do?

[mitchellchou]

In this case do we just use deposit as default? and shall we swap the position of the tabs if we do?

I think "vote" should be default when we don't know its staus
Because most of the proposals on likecoin mainnet are passed proposals that already have vote panel

but anyway this is not urgent wor~~

[hochiw]

yes but I found it a bit weird if it goes
Enter page -> see votes panel -> fetch proposal detail -> check if deposit period -> hide votes panel and navigate to deposit panel

but anyway this is not urgent wor~~

yes but since I am working on the same page I figured I might as well handle this xd, i am handling moniker first and will come back later for this

[mitchellchou]

Then I think we should drop this spec as deposit proposals are few?

didn't expect we need a param to switch between vote/deposit.
for vote/deposit result can't they render after fetch proposal detail?

[hochiw]

I figured that it would be painful to manage two pagination controls in a single screen so I separated the components :sadFrog: