Merge pull request #218 from mcg-web/protect-against-duplicated-mapping-file

Protect against duplicate mapping file

Author: mcg-web

DependencyInjection/OverblogGraphQLTypesExtension.php

@@ -36,6 +36,8 @@ class OverblogGraphQLTypesExtension extends Extension
         ],
     ];
 
+    private $treatedFiles = [];
+
     const DEFAULT_TYPES_SUFFIX = '.types';
 
     public function load(array $configs, ContainerBuilder $container)
@@ -49,7 +51,8 @@ public function load(array $configs, ContainerBuilder $container)
     public function containerPrependExtensionConfig(array $config, ContainerBuilder $container)
     {
         $typesMappings = $this->mappingConfig($config, $container);
-
+        // reset treated files
+        $this->treatedFiles = [];
         // treats mappings
         foreach ($typesMappings as $params) {
             $this->prependExtensionConfigFromFiles($params['type'], $params['files'], $container);
@@ -63,12 +66,17 @@ public function containerPrependExtensionConfig(array $config, ContainerBuilder
      */
     private function prependExtensionConfigFromFiles($type, $files, ContainerBuilder $container)
     {
-        /** @var SplFileInfo $file */
         foreach ($files as $file) {
+            $fileRealPath = $file->getRealPath();
+            if (isset($this->treatedFiles[$fileRealPath])) {
+                continue;
+            }
+
             $parserClass = sprintf('Overblog\\GraphQLBundle\\Config\\Parser\\%sParser', ucfirst($type));
 
             $typeConfig = call_user_func($parserClass.'::parse', $file, $container);
             $container->prependExtensionConfig($this->getAlias(), $typeConfig);
+            $this->treatedFiles[$file->getRealPath()] = true;
         }
     }
 

Tests/Functional/App/config/access/config.yml

@@ -16,3 +16,7 @@ overblog_graphql:
                 -
                     type: yaml
                     dir: "%kernel.root_dir%/config/access/mapping"
+                # include the same files twice
+                -
+                    type: yaml
+                    dir: "%kernel.root_dir%/config/access/mapping"