Skip to content

Commit bbde701

Browse files
committed
Merge tag 'v3.2.1' into overleaf
Release 3.2.1
2 parents fa6c931 + 6ba76ba commit bbde701

15 files changed

+13204
-747
lines changed

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,7 @@ node_modules/
55
yarn-error.log
66
.DS_Store
77
.eslintcache
8-
.dir-locals.el
8+
.dir-locals.el
9+
10+
## Local VS code settings and debug profiles
11+
.vscode

CHANGELOG.md

Lines changed: 240 additions & 61 deletions
Large diffs are not rendered by default.

README.md

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ type Profile = {
127127
- `additionalAuthorizeParams`: dictionary of additional query params to add to 'authorize' requests
128128
- `identifierFormat`: optional name identifier format to request from identity provider (default: `urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress`)
129129
- `wantAssertionsSigned`: if truthy, add `WantAssertionsSigned="true"` to the metadata, to specify that the IdP should always sign the assertions.
130-
- `acceptedClockSkewMs`: Time in milliseconds of skew that is acceptable between client and server when checking `OnBefore` and `NotOnOrAfter` assertion condition validity timestamps. Setting to `-1` will disable checking these conditions entirely. Default is `0`.
130+
- `acceptedClockSkewMs`: Time in milliseconds of skew that is acceptable between client and server when checking `NotBefore` and `NotOnOrAfter` assertion condition validity timestamps. Setting to `-1` will disable checking these conditions entirely. Default is `0`.
131131
- `maxAssertionAgeMs`: Amount of time after which the framework should consider an assertion expired. If the limit imposed by this variable is stricter than the limit imposed by `NotOnOrAfter`, this limit will be used when determining if an assertion is expired.
132132
- `attributeConsumingServiceIndex`: optional `AttributeConsumingServiceIndex` attribute to add to AuthnRequest to instruct the IDP which attribute set to attach to the response ([link](http://blog.aniljohn.com/2014/01/data-minimization-front-channel-saml-attribute-requests.html))
133133
- `disableRequestedAuthnContext`: if truthy, do not request a specific authentication context. This is [known to help when authenticating against Active Directory](https://github.com/node-saml/passport-saml/issues/226) (AD FS) servers.
@@ -359,28 +359,19 @@ To support this scenario you can provide an implementation for a cache provider
359359

360360
```javascript
361361
{
362-
save: function(key, value, callback) {
363-
// save the key with the optional value, invokes the callback with the value saves
362+
saveAsync: async function(key, value) {
363+
// saves the key with the optional value, returns the saved value
364364
},
365-
get: function(key, callback) {
366-
// invokes 'callback' and passes the value if found, null otherwise
365+
getAsync: async function(key) {
366+
// returns the value if found, null otherwise
367367
},
368-
remove: function(key, callback) {
369-
// removes the key from the cache, invokes `callback` with the
368+
removeAsync: async function(key) {
369+
// removes the key from the cache, returns the
370370
// key removed, null if no key is removed
371371
}
372372
}
373373
```
374374

375-
The `callback` argument is a function in the style of normal Node callbacks:
376-
377-
```
378-
function callback(err, result)
379-
{
380-
381-
}
382-
```
383-
384375
Provide an instance of an object which has these functions passed to the `cacheProvider` config option when using Passport-SAML.
385376

386377
## SLO (single logout)

0 commit comments

Comments
 (0)