Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Donor/Specimen/Sample - from Analysis Entity Classes #864

Open
joneubank opened this issue Oct 2, 2024 · 0 comments
Open

Remove Donor/Specimen/Sample - from Analysis Entity Classes #864

joneubank opened this issue Oct 2, 2024 · 0 comments
Assignees
Labels
breaking-change Changes to the code might result in breaking-changes refactor-analysis-data-model

Comments

@joneubank
Copy link
Contributor

This ticket is contributing to the epic: #863

Summary

Update Analysis data classes in Song to remove Donor, Specimen, and Sample.

Since these classes are used throughout the code base this will break many other classes, so references to these properties should be removed and cleaned up so that the code base can still build without these properties.

Details

The classes that need to be updated are:

  1. bio.overture.song.core.model.Analysis
  2. bio.overture.song.server.model.analysis.Analysis
  3. bio.overture.song.server.model.analysis.DataEntity

From these classes we need to remove all hardcoded references to donor, specimen, and sample classes, or IDs representing these entities.

Additional context

As part of this ticket, we don't need to remove the classes representing the Donor, Specimen, or Sample entities. We will remove all uses of these classes and then remove the code for these classes and their correspondign repositories once analyses are stable without them.

@joneubank joneubank changed the title Remove Donor/Specimen/Sample - from Entity Classes Remove Donor/Specimen/Sample - from Analysis Entity Classes Oct 2, 2024
@joneubank joneubank added the breaking-change Changes to the code might result in breaking-changes label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes to the code might result in breaking-changes refactor-analysis-data-model
Projects
None yet
Development

No branches or pull requests

2 participants