Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Don't allow dots in schema/field names #58

Open
blabadi opened this issue Nov 2, 2019 · 1 comment
Open

BUG - Don't allow dots in schema/field names #58

blabadi opened this issue Nov 2, 2019 · 1 comment
Assignees
Labels
bug Something isn't working co-options options for co-op students

Comments

@blabadi
Copy link
Contributor

blabadi commented Nov 2, 2019

Dots should not be allowed in schema names or field names.

Description

we use the dot internally to combine schema name and field name, having dots in any of those two names, will make splitting based on dot impossible.
see the diff endpoint on how the response is combined [schema_name.field_name]

Expected Behaviour

Users should not be allowed to use dots, and receive validation error if they attempt that

Actual Behaviour

Dots are accepted

@blabadi blabadi added the bug Something isn't working label Nov 2, 2019
@rosibaj rosibaj added the co-options options for co-op students label Dec 11, 2019
@joneubank
Copy link
Contributor

Functionality is now in place, needs test cases added.

@joneubank joneubank self-assigned this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working co-options options for co-op students
Projects
None yet
Development

No branches or pull requests

3 participants