Skip to content

Commit 5f72e5d

Browse files
committed
Merge remote-tracking branch 'origin/dev'
2 parents c9069eb + 10da1de commit 5f72e5d

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

build/rollup.config.base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default {
1616
}),
1717
alias({
1818
entries: [
19-
{ find: /@\//, replacement: `${path.resolve(__dirname, '../src/')}` },
19+
{ find: /@\/(.*)/, replacement: `${path.resolve(__dirname, '../src/$1')}` },
2020
],
2121
}),
2222
postcss(),

src/classes/Icon.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"Icon":"Polaris-Icon","applyColor":"Polaris-Icon--applyColor","hasBackdrop":"Polaris-Icon--hasBackdrop","colorBase":"Polaris-Icon--colorBase","colorSubdued":"Polaris-Icon--colorSubdued","colorCritical":"Polaris-Icon--colorCritical","colorInteractive":"Polaris-Icon--colorInteractive","colorWarning":"Polaris-Icon--colorWarning","colorHighlight":"Polaris-Icon--colorHighlight","colorSuccess":"Polaris-Icon--colorSuccess","colorPrimary":"Polaris-Icon--colorPrimary","Svg":"Polaris-Icon__Svg","Img":"Polaris-Icon__Img","Placeholder":"Polaris-Icon__Placeholder"}
1+
{"Icon":"Polaris-Icon","applyColor":"Polaris-Icon--applyColor","hasBackdrop":"Polaris-Icon--hasBackdrop","colorBase":"Polaris-Icon--colorBase","colorSubdued":"Polaris-Icon--colorSubdued","colorCritical":"Polaris-Icon--colorCritical","colorInteractive":"Polaris-Icon--colorInteractive","colorWarning":"Polaris-Icon--colorWarning","colorHighlight":"Polaris-Icon--colorHighlight","colorSuccess":"Polaris-Icon--colorSuccess","colorPrimary":"Polaris-Icon--colorPrimary","Img":"Polaris-Icon__Img","Svg":"Polaris-Icon__Svg","Placeholder":"Polaris-Icon__Placeholder"}

src/components/Icon/Icon.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import { classNames, variationName } from 'polaris-react/src/utilities/css';
2626
import type { IconSource } from 'types/type';
2727
import styles from '@/classes/Icon.json';
2828
import { VisuallyHidden } from '../VisuallyHidden';
29+
import config from '@/config';
2930
3031
export const getPolarisIcon = async (
3132
iconName: string,
@@ -140,7 +141,7 @@ export default class Icon extends Vue {
140141
if (
141142
this.color
142143
&& this.sourceType === 'external'
143-
&& process.env.NODE_ENV === 'development'
144+
&& config.env === 'development'
144145
) {
145146
// eslint-disable-next-line no-console
146147
console.warn(
@@ -154,7 +155,7 @@ export default class Icon extends Vue {
154155
this.backdrop
155156
&& this.color
156157
&& !COLORS_WITH_BACKDROPS.includes(this.color)
157-
&& process.env.NODE_ENV === 'development'
158+
&& config.env === 'development'
158159
) {
159160
// eslint-disable-next-line no-console
160161
console.warn(

src/components/InlineError/InlineError.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ div(:id="wrapperID", :class="wrapperClassName")
1212
<script lang="ts">
1313
import Vue from 'vue';
1414
import { Component, Prop } from 'vue-property-decorator';
15+
import type { Error } from 'types/type';
1516
import styles from '@/classes/InlineError.json';
16-
import type { Error } from '@/type';
1717
import { Icon } from '../Icon';
1818
1919
export const errorTextID = (id: string): string => `${id}Error`;

src/config/index.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export default {
2+
env: process.env.NODE_ENV,
3+
};

0 commit comments

Comments
 (0)