Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load view solutions page #34

Open
pradeepbishnoi opened this issue Jul 12, 2021 · 1 comment
Open

Lazy load view solutions page #34

pradeepbishnoi opened this issue Jul 12, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@pradeepbishnoi
Copy link
Contributor

Currently if you open the 'view solutions' of problem 1 - it goes into a frozen state and then after a minute or so it shows up all solutions. Will be good user experience to load first 5-10 solutions and then on scroll down bring the next 10 etc.

https://4clojure.oxal.org/#/problem/1/solutions

Also, can think for creating a Set and remove duplicate solutions. Look at the screenshot with duplicate solution for problem 1 (it might be the case for other as well). Better will be to clean the solutions data one time (remove duplicate) and store it.

image

@borkdude
Copy link
Collaborator

Yes. It might not be so much the amount of data, but the amount of rendering might take the most of the time. React is known to not work well with large lists. So maybe it's good to first find out if that's the bottleneck or not. React Virtualized offers a solution for rendering larger lists well, perhaps there are also other solutions. @oxalorg

@oxalorg oxalorg added the enhancement New feature or request label Jul 12, 2021
oxalorg added a commit that referenced this issue Jul 12, 2021
as mentioned in #34 some of the solutions take too much time to load, so
limit it to 1000 solutions before a more appropriate lazy pagination
solution is implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants