Skip to content

Commit dd857f7

Browse files
DunqingDunqing
committed
chore(transformer): enable Babel's private-property-in-property plugin tests
1 parent 1fcc363 commit dd857f7

File tree

3 files changed

+218
-3
lines changed

3 files changed

+218
-3
lines changed

‎tasks/transform_conformance/snapshots/babel.snap.md

Lines changed: 180 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
commit: 54a8389f
22

3-
Passed: 661/1095
3+
Passed: 661/1154
44

55
# All Passed:
66
* babel-plugin-transform-logical-assignment-operators
@@ -811,6 +811,185 @@ x Output mismatch
811811
x Output mismatch
812812

813813

814+
# babel-plugin-transform-private-property-in-object (0/59)
815+
* assumption-privateFieldsAsProperties/accessor/input.js
816+
x Output mismatch
817+
818+
* assumption-privateFieldsAsProperties/compiled-classes/input.js
819+
x Output mismatch
820+
821+
* assumption-privateFieldsAsProperties/field/input.js
822+
x Output mismatch
823+
824+
* assumption-privateFieldsAsProperties/method/input.js
825+
x Output mismatch
826+
827+
* assumption-privateFieldsAsProperties/nested-class/input.js
828+
x Output mismatch
829+
830+
* assumption-privateFieldsAsProperties/nested-class-other-redeclared/input.js
831+
x Output mismatch
832+
833+
* assumption-privateFieldsAsProperties/nested-class-redeclared/input.js
834+
x Output mismatch
835+
836+
* assumption-privateFieldsAsProperties/static-accessor/input.js
837+
x Output mismatch
838+
839+
* assumption-privateFieldsAsProperties/static-field/input.js
840+
x Output mismatch
841+
842+
* assumption-privateFieldsAsProperties/static-method/input.js
843+
x Output mismatch
844+
845+
* assumption-privateFieldsAsSymbols/accessor/input.js
846+
x Output mismatch
847+
848+
* assumption-privateFieldsAsSymbols/compiled-classes/input.js
849+
x Output mismatch
850+
851+
* assumption-privateFieldsAsSymbols/field/input.js
852+
x Output mismatch
853+
854+
* assumption-privateFieldsAsSymbols/method/input.js
855+
x Output mismatch
856+
857+
* assumption-privateFieldsAsSymbols/nested-class/input.js
858+
x Output mismatch
859+
860+
* assumption-privateFieldsAsSymbols/nested-class-other-redeclared/input.js
861+
x Output mismatch
862+
863+
* assumption-privateFieldsAsSymbols/nested-class-redeclared/input.js
864+
x Output mismatch
865+
866+
* assumption-privateFieldsAsSymbols/static-accessor/input.js
867+
x Output mismatch
868+
869+
* assumption-privateFieldsAsSymbols/static-field/input.js
870+
x Output mismatch
871+
872+
* assumption-privateFieldsAsSymbols/static-method/input.js
873+
x Output mismatch
874+
875+
* private/accessor/input.js
876+
x Output mismatch
877+
878+
* private/field/input.js
879+
x Output mismatch
880+
881+
* private/method/input.js
882+
x Output mismatch
883+
884+
* private/native-classes/input.js
885+
x Output mismatch
886+
887+
* private/nested-class/input.js
888+
x Output mismatch
889+
890+
* private/nested-class-other-redeclared/input.js
891+
x Output mismatch
892+
893+
* private/nested-class-redeclared/input.js
894+
x Output mismatch
895+
896+
* private/static-accessor/input.js
897+
x Output mismatch
898+
899+
* private/static-field/input.js
900+
x Output mismatch
901+
902+
* private/static-method/input.js
903+
x Output mismatch
904+
905+
* private/static-shadow/input.js
906+
x Output mismatch
907+
908+
* private-loose/accessor/input.js
909+
x Output mismatch
910+
911+
* private-loose/field/input.js
912+
x Output mismatch
913+
914+
* private-loose/method/input.js
915+
x Output mismatch
916+
917+
* private-loose/native-classes/input.js
918+
x Output mismatch
919+
920+
* private-loose/nested-class/input.js
921+
x Output mismatch
922+
923+
* private-loose/nested-class-other-redeclared/input.js
924+
x Output mismatch
925+
926+
* private-loose/nested-class-redeclared/input.js
927+
x Output mismatch
928+
929+
* private-loose/static-accessor/input.js
930+
x Output mismatch
931+
932+
* private-loose/static-field/input.js
933+
x Output mismatch
934+
935+
* private-loose/static-method/input.js
936+
x Output mismatch
937+
938+
* private-loose/static-shadow/input.js
939+
x Output mismatch
940+
941+
* to-native-fields/accessor/input.js
942+
x Output mismatch
943+
944+
* to-native-fields/class-expression-in-default-param/input.js
945+
x Output mismatch
946+
947+
* to-native-fields/class-expression-instance/input.js
948+
x Output mismatch
949+
950+
* to-native-fields/class-expression-static/input.js
951+
x Output mismatch
952+
953+
* to-native-fields/field/input.js
954+
x Output mismatch
955+
956+
* to-native-fields/half-constructed-instance/input.js
957+
x Output mismatch
958+
959+
* to-native-fields/half-constructed-static/input.js
960+
x Output mismatch
961+
962+
* to-native-fields/method/input.js
963+
x Output mismatch
964+
965+
* to-native-fields/multiple-checks/input.js
966+
x Output mismatch
967+
968+
* to-native-fields/nested-class/input.js
969+
x Output mismatch
970+
971+
* to-native-fields/nested-class-other-redeclared/input.js
972+
x Output mismatch
973+
974+
* to-native-fields/nested-class-redeclared/input.js
975+
x Output mismatch
976+
977+
* to-native-fields/static-accessor/input.js
978+
x Output mismatch
979+
980+
* to-native-fields/static-field/input.js
981+
x Output mismatch
982+
983+
* to-native-fields/static-method/input.js
984+
x Output mismatch
985+
986+
* to-native-fields/static-shadow/input.js
987+
x Output mismatch
988+
989+
* to-native-fields/static-shadowed-binding/input.js
990+
x Output mismatch
991+
992+
814993
# babel-plugin-transform-nullish-coalescing-operator (5/12)
815994
* assumption-noDocumentAll/transform/input.js
816995
x Output mismatch

‎tasks/transform_conformance/snapshots/babel_exec.snap.md

Lines changed: 37 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ commit: 54a8389f
22

33
node: v22.12.0
44

5-
Passed: 283 of 362 (78.18%)
5+
Passed: 283 of 374 (75.67%)
66

77
Failures:
88

@@ -414,6 +414,42 @@ TypeError: "#privateStaticFieldValue" is write-only
414414
at Function.getPrivateStaticFieldValue (./tasks/transform_conformance/fixtures/babel/babel-plugin-transform-private-methods-test-fixtures-static-accessors-privateFieldsAsSymbols-get-only-setter-exec.test.js:7:15)
415415
at ./tasks/transform_conformance/fixtures/babel/babel-plugin-transform-private-methods-test-fixtures-static-accessors-privateFieldsAsSymbols-get-only-setter-exec.test.js:14:12
416416

417+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-assumption-privateFieldsAsProperties-method-exec.test.js
418+
Private field '#foo' must be declared in an enclosing class
419+
420+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-assumption-privateFieldsAsProperties-rhs-not-object-exec.test.js
421+
Private field '#p' must be declared in an enclosing class
422+
423+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-assumption-privateFieldsAsSymbols-method-exec.test.js
424+
Private field '#foo' must be declared in an enclosing class
425+
426+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-assumption-privateFieldsAsSymbols-rhs-not-object-exec.test.js
427+
Private field '#p' must be declared in an enclosing class
428+
429+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-private-loose-rhs-not-object-exec.test.js
430+
Private field '#p' must be declared in an enclosing class
431+
432+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-private-loose-static-shadow-exec.test.js
433+
Private field '#x' must be declared in an enclosing class
434+
435+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-private-rhs-not-object-exec.test.js
436+
Private field '#p' must be declared in an enclosing class
437+
438+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-private-static-shadow-exec.test.js
439+
Private field '#x' must be declared in an enclosing class
440+
441+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-to-native-fields-half-constructed-instance-exec.test.js
442+
Private field '#w' must be declared in an enclosing class
443+
444+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-to-native-fields-half-constructed-static-exec.test.js
445+
Private field '#w' must be declared in an enclosing class
446+
447+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-to-native-fields-rhs-not-object-exec.test.js
448+
Private field '#p' must be declared in an enclosing class
449+
450+
./fixtures/babel/babel-plugin-transform-private-property-in-object-test-fixtures-to-native-fields-static-shadow-exec.test.js
451+
Private field '#x' must be declared in an enclosing class
452+
417453
./fixtures/babel/babel-preset-env-test-fixtures-plugins-integration-issue-15170-exec.test.js
418454
AssertionError: expected [Function] to not throw an error but 'ReferenceError: x is not defined' was thrown
419455
at Proxy.<anonymous> (./node_modules/.pnpm/@vitest+expect@2.1.2/node_modules/@vitest/expect/dist/index.js:1438:21)

‎tasks/transform_conformance/src/constants.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ pub const PLUGINS: &[&str] = &[
66
"babel-plugin-transform-class-properties",
77
"babel-plugin-transform-class-static-block",
88
"babel-plugin-transform-private-methods",
9-
// "babel-plugin-transform-private-property-in-object",
9+
"babel-plugin-transform-private-property-in-object",
1010
// // [Syntax] "babel-plugin-transform-syntax-top-level-await",
1111
// ES2021
1212
"babel-plugin-transform-logical-assignment-operators",

0 commit comments

Comments
 (0)