Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thermal shouldn't be so twitchy #1785

Open
Aaron-Hartwig opened this issue May 17, 2024 · 0 comments
Open

thermal shouldn't be so twitchy #1785

Aaron-Hartwig opened this issue May 17, 2024 · 0 comments

Comments

@Aaron-Hartwig
Copy link
Contributor

If a single measurement comes in over the high input limit, the thermal loop will disable the system. This is aggressive and can cause the system to shutdown with a spurious measurement.

For example, consider this ringbuf that shows a system sitting with 0% PWM and then being shut down due to a single spurious measurement:

  27  982        4     4328 ControlPwm(0x0)
  28  897        4        1 AutoState(Uncontrollable)
  29  986        4        1 PowerDownAt(0x49f6e3)
  30  770        4        1 PowerModeChanged(PowerBitmask(0b1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant