Skip to content

Commit 0995c5e

Browse files
authored
Change LocalStorage dataset to non-zoned (#9404)
I misunderstood the meaning of the `zoned` function on DatasetKind. Correct this by returning false for LocalStorage.
1 parent 5060045 commit 0995c5e

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

common/src/api/internal/shared.rs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1001,15 +1001,20 @@ impl DatasetKind {
10011001
}
10021002

10031003
/// Returns true if this dataset is delegated to a non-global zone.
1004+
///
1005+
/// Note: the `zoned` property of a dataset controls whether or not a
1006+
/// dataset is managed from a non-global zone. This function's intent is
1007+
/// different in the sense that it's asking whether or not a dataset will be
1008+
/// delegated to a non-global zone, not managed by a non-global zone.
10041009
pub fn zoned(&self) -> bool {
10051010
use DatasetKind::*;
10061011
match self {
10071012
Cockroach | Crucible | Clickhouse | ClickhouseKeeper
10081013
| ClickhouseServer | ExternalDns | InternalDns => true,
10091014

1010-
TransientZoneRoot | TransientZone { .. } | Debug => false,
1011-
1012-
LocalStorage => true,
1015+
TransientZoneRoot | TransientZone { .. } | Debug | LocalStorage => {
1016+
false
1017+
}
10131018
}
10141019
}
10151020

0 commit comments

Comments
 (0)