-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/2.3.1 #58
base: master
Are you sure you want to change the base?
Release/2.3.1 #58
Conversation
@oxyno-zeta I hope you're not bothered by me requesting reviews for these pull requests! Let me know if there's anything I can do to make things easier for you. I've already tested this myself in the dev app, but wanted to make sure you're okay with my changes before merging into master. And you also have npm publish rights! 😄 |
Hello @Phanabani , Thanks a lot for developing on this project. Reviewing your pull requests is always a pleasure. One quick question: why do you consider the freeze as a fix and not a feature? I'm not telling you to change because can be both for me, just wondering. Will read as soon as possible. May be next week if it isn't today (holidays tomorrow ;) ). Oxyno-zeta |
Hi @oxyno-zeta! I'm happy that you appreciate my work! It means a lot to me. I considered the freeze as a fix and not a feature because the user mutating I hope you have a good holiday weekend! 😄 |
2.3.1
Fix
keyPath
, thestring[]
argument in many callback functions, is now frozen, so mistakenly trying to mutate it will throw an errordev_app
's read-only function checkbox throwing an errordev_app
(no longer uses unnecessary refs)Docs
inputElement