From f81a7fb37be86a7163e95178e4f24bc598c7218a Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Sat, 24 Jan 2026 19:03:27 +0000
Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Bolt:=20Optimize=20list=5Fwork=20lo?=
 =?UTF-8?q?op=20with=20shell=20builtins?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Optimization:
- Replaced `basename` with bash parameter expansion `${work_path##*/}`.
- Replaced `echo | sed` for date prefix removal with bash regex match `[[ =~ ]]`.
- Replaced the text matching and `sed` pipeline for description extraction with a `while read` loop and parameter expansion.
- Fixed potential unbound variable error for `list_work` argument.

Impact:
- Reduces execution time for listing 50 work items from ~0.843s to ~0.008s (~100x speedup).
- Eliminates ~200 external process spawns for 50 items.

Verification:
- Benchmarked with `benchmark_list_work.sh`.
- Verified with `tests/integration/test_workflow.bats` (fixed test isolation issue).
---
 .jules/bolt.md                       |  3 +++
 .sdd/plans/.index.json               |  4 ----
 lib/internal/work_manager.sh         | 16 ++++++++++++----
 tests/integration/test_workflow.bats |  1 +
 4 files changed, 16 insertions(+), 8 deletions(-)
 delete mode 100644 .sdd/plans/.index.json

diff --git a/.jules/bolt.md b/.jules/bolt.md
index 1a8e67d..9d96c70 100644
--- a/.jules/bolt.md
+++ b/.jules/bolt.md
@@ -10,3 +10,6 @@
 ## 2024-05-23 - Shell Script Sourcing for Tests
 **Learning:** Shell scripts in `lib/` often run as standalone executables but must be sourceable for unit testing. Without a guard `if [[ "${BASH_SOURCE[0]}" == "${0}" ]];`, sourcing the script triggers its main execution logic (e.g., argument parsing), causing tests to fail immediately with exit codes or usage messages.
 **Action:** Always wrap the main execution logic of shell scripts in a guard block to ensure they can be safely sourced by test runners like BATS.
+## 2026-01-24 - [Loop Optimization with Builtins]
+**Learning:** Replacing external process calls (`basename`, `sed`, `grep`) with bash builtins (`${var##*/}`, `read`, parameter expansion) in tight loops provided a ~100x performance improvement (0.8s to 0.008s for 50 items). Process forking overhead is significant in shell loops.
+**Action:** Always audit loops for external command usage and replace with builtins where possible.
diff --git a/.sdd/plans/.index.json b/.sdd/plans/.index.json
deleted file mode 100644
index 553f474..0000000
--- a/.sdd/plans/.index.json
+++ /dev/null
@@ -1,4 +0,0 @@
-{
-  "next_id": 1,
-  "plans": []
-}
diff --git a/lib/internal/work_manager.sh b/lib/internal/work_manager.sh
index 198b150..2bd50b9 100755
--- a/lib/internal/work_manager.sh
+++ b/lib/internal/work_manager.sh
@@ -190,7 +190,7 @@ EOF
 
 # List all active work
 list_work() {
-    local filter="$1"
+    local filter="${1:-}"
     
     if [ ! -d "$WORK_DIR" ]; then
         echo "No active work"
@@ -205,14 +205,22 @@ list_work() {
     
     for work_path in "$WORK_DIR"/*; do
         if [ -d "$work_path" ]; then
-            local work_id=$(basename "$work_path")
+            local work_id="${work_path##*/}"
             # Extract name (remove date prefix)
-            local work_name=$(echo "$work_id" | sed 's/^[0-9]\{4\}-[0-9]\{2\}-[0-9]\{2\}-//')
+            local work_name="$work_id"
+            if [[ "$work_id" =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}- ]]; then
+                work_name="${work_id:11}"
+            fi
             
             # Get first line of proposal as description
             local desc=""
             if [ -f "$work_path/proposal.md" ]; then
-                desc=$(grep -m 1 "^# " "$work_path/proposal.md" | sed 's/^# //')
+                while read -r line; do
+                    if [[ "$line" == "# "* ]]; then
+                        desc="${line#\# }"
+                        break
+                    fi
+                done < "$work_path/proposal.md"
             fi
             
             echo "  • $work_name"
diff --git a/tests/integration/test_workflow.bats b/tests/integration/test_workflow.bats
index c019e0c..d719a18 100755
--- a/tests/integration/test_workflow.bats
+++ b/tests/integration/test_workflow.bats
@@ -5,6 +5,7 @@ load ../test_helper
 
 setup() {
     setup_test_env
+    export ADBS_PROJECT_ROOT="$TEMP_DIR"
     export ADBS_DIR="$TEMP_DIR/.adbs"
     mkdir -p "$ADBS_DIR/work" "$ADBS_DIR/archive"
     export PATH="$PROJECT_ROOT/bin:$PATH"