Skip to content

Fix string comparison in PChecker runtime #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lewisbru wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix string comparison in PChecker runtime #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions Src/PChecker/CheckerCore/Runtime/Values/PString.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,73 +92,73 @@ private PString(string value)
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator <(in PString pString1, in PString pString2)
{
return string.Compare(pString1.value, pString2.value) == -1;
return string.Compare(pString1.value, pString2.value) < 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator <(in IPValue pValue1, in PString pValue2)
{
return pValue1 is PString pString && string.Compare(pString.value, pValue2.value) == -1;
return pValue1 is PString pString && string.Compare(pString.value, pValue2.value) < 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator <(in PString pValue1, in IPValue pValue2)
{
return pValue2 is PString pString && string.Compare(pString.value, pValue1.value) == -1;
return pValue2 is PString pString && string.Compare(pString.value, pValue1.value) < 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator >(in PString pString1, in PString pString2)
{
return string.Compare(pString1.value, pString2.value) == 1;
return string.Compare(pString1.value, pString2.value) > 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator >(in IPValue pValue1, in PString pValue2)
{
return pValue1 is PString pString && string.Compare(pString.value, pValue2.value) == 1;
return pValue1 is PString pString && string.Compare(pString.value, pValue2.value) > 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator >(in PString pValue1, in IPValue pValue2)
{
return pValue2 is PString pString && string.Compare(pString.value, pValue1.value) == 1;
return pValue2 is PString pString && string.Compare(pString.value, pValue1.value) > 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator <=(in PString pString1, in PString pString2)
{
return string.Compare(pString1.value, pString2.value) != 1;
return string.Compare(pString1.value, pString2.value) <= 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator <=(in IPValue pValue1, in PString pValue2)
{
return pValue1 is PString pString && string.Compare(pString.value, pValue2.value) != 1;
return pValue1 is PString pString && string.Compare(pString.value, pValue2.value) <= 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator <=(in PString pValue1, in IPValue pValue2)
{
return pValue2 is PString pString && string.Compare(pString.value, pValue1.value) != 1;
return pValue2 is PString pString && string.Compare(pString.value, pValue1.value) <= 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator >=(in PString pString1, in PString pString2)
{
return string.Compare(pString1.value, pString2.value) != -1;
return string.Compare(pString1.value, pString2.value) >= 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator >=(in IPValue pValue1, in PString pValue2)
{
return pValue1 is PString pString && string.Compare(pString.value, pValue2.value) != -1;
return pValue1 is PString pString && string.Compare(pString.value, pValue2.value) >= 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static PBool operator >=(in PString pValue1, in IPValue pValue2)
{
return pValue2 is PString pString && string.Compare(pString.value, pValue1.value) != -1;
return pValue2 is PString pString && string.Compare(pString.value, pValue1.value) >= 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
Expand Down Expand Up @@ -194,4 +194,4 @@ public object ToDict()
return ToString();
}
}
}
}
Loading