From fa0ec8ba81a0931ef9d087e6df91e08ac07fad7c Mon Sep 17 00:00:00 2001 From: Andrew Date: Wed, 20 Nov 2024 19:52:10 -0800 Subject: [PATCH] Add tickets to TODOs --- src/commands/scp.ts | 3 +-- src/commands/ssh.ts | 3 +-- src/plugins/azure/ssh.ts | 3 ++- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/commands/scp.ts b/src/commands/scp.ts index 8b87259..ba5de2f 100644 --- a/src/commands/scp.ts +++ b/src/commands/scp.ts @@ -84,8 +84,7 @@ const scpAction = async (args: yargs.ArgumentsCamelCase) => { : []; args.sshOptions = sshOptions; - // Azure SSH currently doesn't support specifying a port; throw an error if one is set. Azure Bastion only supports - // port 22 for SSH connections. + // TODO(ENG-3142): Azure SSH currently doesn't support specifying a port; throw an error if one is set. if ( args.provider === "azure" && sshOptions.some((opt) => opt.startsWith("-P")) diff --git a/src/commands/ssh.ts b/src/commands/ssh.ts index 0c34658..7dc9646 100644 --- a/src/commands/ssh.ts +++ b/src/commands/ssh.ts @@ -89,8 +89,7 @@ const sshAction = async (args: yargs.ArgumentsCamelCase) => { : []; args.sshOptions = sshOptions; - // Azure SSH currently doesn't support specifying a port; throw an error if one is set. Azure Bastion only supports - // port 22 for SSH connections. + // TODO(ENG-3142): Azure SSH currently doesn't support specifying a port; throw an error if one is set. if ( args.provider === "azure" && sshOptions.some((opt) => opt.startsWith("-p")) diff --git a/src/plugins/azure/ssh.ts b/src/plugins/azure/ssh.ts index ee88daa..2b45546 100644 --- a/src/plugins/azure/ssh.ts +++ b/src/plugins/azure/ssh.ts @@ -64,8 +64,9 @@ export const azureSshProvider: SshProvider< reproCommands: () => undefined, setup: async (request) => { - // TODO: Does this specifically need to be the subscription ID for the Bastion? + // TODO(ENG-3129): Does this specifically need to be the subscription ID for the Bastion? await azLogin(request.subscriptionId); // Always re-login to Azure CLI + const { path: keyPath, cleanup: sshKeyPathCleanup } = await createTempDirectoryForKeys(); await generateSshKeyAndAzureAdCert(keyPath);