updated how we update idps (#161)

Signed-off-by: Garth <244253+xgp@users.noreply.github.com>

Author: xgp

src/main/java/io/phasetwo/service/resource/IdentityProvidersResource.java

@@ -18,6 +18,7 @@
 import lombok.extern.jbosslog.JBossLog;
 import org.keycloak.models.IdentityProviderModel;
 import org.keycloak.models.utils.ModelToRepresentation;
+import org.keycloak.models.utils.RepresentationToModel;
 import org.keycloak.models.utils.StripSecretsUtils;
 import org.keycloak.representations.idm.ComponentRepresentation;
 import org.keycloak.representations.idm.IdentityProviderRepresentation;
@@ -119,10 +120,10 @@ public Response createIdentityProvider(IdentityProviderRepresentation representa
     }
 
     idpDefaults(representation, Optional.empty());
-    deactivateOtherIdps(representation);
 
     Response resp = getIdpResource().create(representation);
     if (resp.getStatus() == Response.Status.CREATED.getStatusCode()) {
+      deactivateOtherIdps(representation);
       return createdResponse(representation);
     } else {
       return resp;
@@ -164,13 +165,15 @@ public Response linkIdp(LinkIdp linkIdp) {
     if (!Strings.isNullOrEmpty(linkIdp.getPostBrokerFlow())) {
       representation.setPostBrokerLoginFlowAlias(linkIdp.getPostBrokerFlow());
     }
-    deactivateOtherIdps(representation);
 
-    Response resp = getIdpResource().getIdentityProvider(linkIdp.getAlias()).update(representation);
-    if (resp.getStatus() == Response.Status.NO_CONTENT.getStatusCode()) {
+    try {
+      IdentityProviderModel updated = RepresentationToModel.toModel(realm, representation, session);
+      realm.updateIdentityProvider(updated);
+      deactivateOtherIdps(representation);
       return createdResponse(representation);
-    } else {
-      return resp;
+    } catch (Exception e) {
+      throw new InternalServerErrorException(
+          String.format("Error updating IdP %s", representation.getAlias()), e);
     }
   }