Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript protocol parser is not in line with larger messages #83

Open
LivInTheLookingGlass opened this issue Sep 1, 2016 · 2 comments
Open

Javascript protocol parser is not in line with larger messages #83

LivInTheLookingGlass opened this issue Sep 1, 2016 · 2 comments
Labels
javascript protocol

Comments

@LivInTheLookingGlass
Copy link
Collaborator

  1. The size of a Buffer cannot exceed 1GiB in some implementations, 2GiB in others. This means that packets cannot be larger than this, and that received messages cannot be larger than this.
@LivInTheLookingGlass
Copy link
Collaborator Author

Links to #69

@LivInTheLookingGlass
Copy link
Collaborator Author

A data structure level way to fix this would be to implement an extended Buffer type. This is easier on the Javascript side since there is no such limitation on the array size. The standard defines that as 232-1 anyhow, which is larger than the maximum the current protocol allows.

Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javascript protocol
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LivInTheLookingGlass