Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded interface versions #3

Open
ThisAMJ opened this issue Jul 20, 2023 · 0 comments
Open

Hardcoded interface versions #3

ThisAMJ opened this issue Jul 20, 2023 · 0 comments

Comments

@ThisAMJ
Copy link
Member

ThisAMJ commented Jul 20, 2023

The version of ISERVERPLUGINCALLBACKS is hardcoded to 003 in wormhole currently, where it should support any version for compatibility. SST does this to a point, but only for the last digit!!!! Also worth considering is the ISERVERPLUGINHELPERS001 interface, and the nature of the ClientFullyConnect vtable entry.

wormhole/src/main.zig

Lines 147 to 150 in 8da8708

if (!std.mem.eql(u8, std.mem.span(name), "ISERVERPLUGINCALLBACKS003")) {
if (ret) |r| r.* = 0;
return &callbacks;
}

https://github.com/mikesmiffy128/sst/blob/13ad0442a3fde0518ca9133b55796f31652698c9/src/sst.c#L438-L444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant