-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge method for SFE #29
Comments
I feel like because the merge method is not specific to the spatial aspect of the data, this is more appropriate as a PR to batchlor (which already has |
Generally full join filling with 0 is a bad idea, so this is low priority. The correct way is to fill with NA, but this has downstream implications. There already is |
I'm just adding here as we discussed. |
Kind of like
cbind
but not quite. Incbind
, for all methods that I know of, the number of rows must match. Formerge
, the rows don't have to perfectly match. The user interface should follow that of base R'smerge
for data frames whenever applicable, giving options for full join (I think should be default, unlike in base R), left join, right join, and inner join. Give an error when the row names of the two SFE objects have no overlap, and warning when the overlap is small.rowGeometries
are subsetted or padded with empty geometries accordingly.rowGeometries
of the same name but different content in the two SFE objects are treated the same way as in the SFEcbind
method.colGeometries
andannotGeometries
are simply concatenated as incbind
.The text was updated successfully, but these errors were encountered: