Skip to content

Commit fc56a61

Browse files
committed
chore: determine platform and unset vars
1 parent 6d6ce86 commit fc56a61

File tree

5 files changed

+33
-56
lines changed

5 files changed

+33
-56
lines changed

DEVELOPER.md

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,11 @@ We create cross-platform and architecture binaries which are published individua
5151
### Download prebuilt binaries for all platforms
5252

5353
```sh
54-
make libs
54+
./script/ci/build_opt_dependencies.sh libs 15.2.1
5555
```
5656

57+
Tag is optional and defaults to latest
58+
5759
This will run the following script, which will grab the latest prebuilt binaries from GitHub.
5860

5961
```sh
@@ -63,55 +65,65 @@ FETCH_ASSETS=true ./script/ci/check-release-libs.sh --fetch-assets -t v15.2.1
6365
### Building all platform specific npm packages
6466

6567
```sh
66-
make build_opt_deps
68+
./script/ci/build_opt_dependencies.sh build
6769
```
6870

6971
### Building individual platform specific npm package
7072

7173
Supported platforms are
7274

75+
- linux-x64-glibc
76+
- linux-arm64-glibc
77+
- linux-x64-musl
78+
- linux-arm64-musl
79+
- darwin-x64
80+
- darwin-arm64
81+
- windows-x64
82+
83+
You can detect your platform with
84+
7385
```sh
74-
supported_platforms?="linux-x64" "linux-arm64" "darwin-x64" "darwin-arm64" "windows-x64"
86+
./script/ci/build-opt-dependencies.sh determine_platform
7587
```
7688

7789
You can build with one
7890

7991
```sh
80-
make supported_platforms=darwin-arm64 build_opt_deps
92+
supported_platforms=$(./script/ci/build-opt-dependencies.sh determine_platform) ./script/ci/build-opt-dependencies.sh build
8193
```
8294

83-
or multiple
95+
or all
8496

8597
```sh
86-
make supported_platforms="darwin-arm64 darwin-amd64" build_opt_deps
98+
./script/ci/build-opt-dependencies.sh build
8799
```
88100

89101
### Linking arch specific package, for your local build
90102

91103
Make link will try to link all available packages, for all available platforms, and will link any that apply
92104

93105
```sh
94-
make link
106+
./script/ci/build-opt-dependencies.sh
95107
```
96108

97109
You can scope it with `supported_platforms`
98110

99111
```sh
100-
make supported_platforms=darwin-arm64 link
112+
supported_platforms=$(./script/ci/build-opt-dependencies.sh determine_platform) ./script/ci/build-opt-dependencies.sh link
101113
```
102114

103115
### Publishing packages
104116

105117
Dry run publishing optional packages, (default)
106118

107119
```sh
108-
make publish_opt_deps
120+
./script/ci/build-opt-dependencies.sh publish
109121
```
110122

111123
Publishing packages with `--dry-run` option removed.
112124

113125
```sh
114-
make DRY_RUN= publish_opt_deps
126+
PUBLISH=true ./script/ci/build-opt-dependencies.sh publish
115127
```
116128

117129
### Linux x86_64 Task

script/ci/build-and-test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ fi
2020
node --version
2121
npm --version
2222
# Update main package.json optional dependencies versions, with those created earlier
23-
current_platform=$("$SCRIPT_DIR"/build-opt-dependencies.sh)
23+
current_platform=$("$SCRIPT_DIR"/build-opt-dependencies.sh determine_platform)
2424
supported_platforms="$current_platform" "$SCRIPT_DIR"/build-opt-dependencies.sh update
2525
# update lockfile post building updated opt deps
2626
npm ci --ignore-scripts || npm i --ignore-scripts

script/ci/build-opt-dependencies.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,15 @@ if [ -z "${supported_platforms+x}" ]; then
88
fi
99

1010
setup_package_vars(){
11+
unset node_os
12+
unset node_arch
13+
unset node_libc
14+
unset libc
15+
echo $supported_platform
1116
IFS='-' read -r node_os node_arch node_libc <<< "$supported_platform"
17+
export node_os=$node_os
18+
export node_arch=$node_arch
19+
export node_libc=$node_libc
1220
if [ "$node_os" = "windows" ]; then
1321
export node_os="win32"
1422
fi
@@ -46,6 +54,7 @@ build() {
4654
setup_package_vars
4755
echo "Building for $node_os-$node_arch"
4856
echo "Building $node_pkg"
57+
echo "Build $node_libc"
4958
mkdir -p "$node_pkg/prebuilds"
5059
cp -R "$standalone_package" "$node_pkg/prebuilds"
5160
if [ "$node_libc" = "glibc" ]; then

script/ci/determine-platform.sh

Lines changed: 0 additions & 44 deletions
This file was deleted.

script/ci/unpack-and-test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ ls *.gz |xargs -n1 tar -xzf
1313

1414
"$SCRIPT_DIR"/../download-plugins.sh
1515
# Use the determined platform
16-
current_platform=$("$SCRIPT_DIR"/build-opt-dependencies.sh)
16+
current_platform=$("$SCRIPT_DIR"/build-opt-dependencies.sh determine_platform)
1717
supported_platforms="$current_platform" "$SCRIPT_DIR"/build-opt-dependencies.sh build
1818
"$SCRIPT_DIR"/build-and-test.sh

0 commit comments

Comments
 (0)