Test Webhook Button ignores consumer/provider settings

[huehnerlady]

Pre issue-raising checklist

I have already (please mark the applicable with an x):

• Upgraded to the latest Pact Broker OR
• Checked the CHANGELOG to see if the issue I am about to raise has been fixed
• Created an executable example that demonstrates the issue using either a:
  • Dockerfile
  • Git repository with a Travis or Appveyor (or similar) build

Software versions

• Pactflow hosted version

Expected behaviour

I have this webhook page:

When I select a specific provider and click Test Webhook, I expect a webhook call from all possible consumer/provider pairs with this provider.

Example:
I have 30 consumers and 10 providers.

Provider A has 3 consumers. Then I would expect 3 webhooks to be send out.

Actual behaviour

It seems that every possible consumer/provider constellation is send out spamming the endpoint receiving the webhook call.

Steps to reproduce

• Have 2 providers and 2 consumers in a broker, one provider should have each one consumer
• Create webhook
• select 1 provider
• run Test Webhook

You should just get 1 call as the chosen provider has only one consumer. But there will be 2.

Additional information

This issue was initially discussed in the pact slack workspace on the 3rd September 2024.
The conversation can be found here

In there it was pointed out that the logic would be somewhere in the trigger_service.rb.

[mefellows]

Thanks for this. It looks like you also had this option set on the account (I can see a lot of the webhooks that were triggered were actually caused by this setting, and not the other).

[huehnerlady]

@mefellows I did in between, but even without that checkbox it still spams the endpoint when testing it

[YOU54F]

Hey Ruth,

Could you try via an API call, or with the pact_broker-client.

https://github.com/pactflow/example-provider/blob/44af7987b6a7bd992ec4b38f284c109765f45350/Makefile#L98

I believe there may be an issue with the webhook button in pactflow triggering multiple executions that I can recreate, but I get the expected behaviour triggering the webhook directly via API

[github-actions]

🤖 Great news! We've labeled this issue as smartbear-supported and created a tracking ticket in PactFlow's Jira (PACT-2563). We'll keep work public and post updates here. Meanwhile, feel free to check out our docs. Thanks for your patience!

[huehnerlady]

@YOU54F unfortunately I do not seem to have the required permissions to make that API call

I try to get more permisions to do the test call

[huehnerlady]

@YOU54F I got the permissions and you are right, when using the API call there is only one session triggered -> what was expected as we have just one consumer

[YOU54F]

Hi @huehnerlady ,

The duplication of requests from the UI has now been resolved.

I appear to have an issue in our test environment where by webhooks are triggering for pairs I have not specified, I have raised it with the team.

Feel free to try out the webhook behaviour from the UI and let us know how you get on

[huehnerlady]

@YOU54F I am sorry if I missexplained my problem, I am meaning exactly that issue of triggering the webhook for pairs I have not yet specified. I did not experience duplicated requests 😅

[mefellows]

Thanks @huehnerlady, this issue should also now be resolved (triggering the wrong consumer/provider pair) and the issue with sending out too many webhooks - both of these were actually issues in the PactFlow UI and not the underlying Pact Broker.

I think we can close this off?

[huehnerlady]

I tested it and it works now, thanks

[mefellows]

Fantastic, thanks,