PAOPN-456: Refactoring pix block and template #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mateus-picoloto
commented
Jul 24, 2023
mateus-picoloto
commented
| Questions | Answers |
|---|---|
| Issue | https://mundipagg.atlassian.net/browse/PAOPN-456 |
| What? | Refactoring pix block and template. |
| Why? | Follow best practices. |
| How? | Removing business rule code and inline css from phtml and following javascript magento convention. |
Gandalf - Continuous AppSec📌 LembreteEste repositório está sendo monitorando de forma automática e contínua em busca de achados que possam comprometer a segurança da aplicação. 📋 Resumo de achados no repositório magento2
|
mauriciohaygert
approved these changes
Jul 25, 2023
|
Kudos, SonarCloud Quality Gate passed! |
mauriciohaygert
approved these changes
Jul 25, 2023
RafaMelazzo
reviewed
Jul 25, 2023
| { | ||
| $pixHelper = new PixHelper(); | ||
| return $pixHelper->getQrCode($this->getPayment()); | ||
| return __('Copied PIX code!'); |
| "Cancel","Cancel" | ||
| "Cancel","Cancel", | ||
| "Failed to copy! Please, manually copy the code using the field bellow the button.","Failed to copy! Please, manually copy the code using the field bellow the button." | ||
| "Copied PIX code!","Copied PIX code!" |
| "Cancel","Cancelar" | ||
| "Cancel","Cancelar", | ||
| "Failed to copy! Please, manually copy the code using the field bellow the button.","Falha ao copiar! Por favor, copie o código manualmente utilizando o campo abaixo do botão." | ||
| "Copied PIX code!","Código PIX copiado!" |
| @@ -19,15 +19,30 @@ | |||
| use Pagarme\Pagarme\Helper\Payment\Pix as PixHelper; | |||
| class Pix extends Template | |||
There was a problem hiding this comment.
Adiciona uma quebra de linha entre class e use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.