Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Icon Component): Color code is not working on svg icon #203

Open
imsauravsingh opened this issue Dec 27, 2019 · 1 comment
Open

fix(Icon Component): Color code is not working on svg icon #203

imsauravsingh opened this issue Dec 27, 2019 · 1 comment
Assignees

Comments

@imsauravsingh
Copy link
Collaborator

Describe the bug
As a reusable component, there isn't any option to add color code on the SVG icon.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Implemented Icon Component #191'
  2. Click on 'https://user-images.githubusercontent.com/49902237/71409904-315fb980-2669-11ea-960c-e4e0e217e93e.png'
  3. You'll see the default color of SVG is black but you won't be able to change the color code of SVG.

Expected behavior
As a user should have an option to add SVG's color

@vinodloha
Copy link
Collaborator

@salilkapoor As discussed the new approach you are changing for Icons, should fix this problem too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants