Skip to content

Commit 607cdeb

Browse files
authored
Merge pull request #195 from pagesource/feature/fixed-storybook-setup
Feature/fixed storybook setup
2 parents 1652d5d + 2651725 commit 607cdeb

File tree

5 files changed

+27
-4
lines changed

5 files changed

+27
-4
lines changed

.changeset/ten-hornets-join.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'create-universal-react': minor
3+
---
4+
5+
Fixed storybook setup and updated generator-plop version to 1.1.1

templates/common/storybook/.storybook/main.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
const TsconfigPathsPlugin = require('tsconfig-paths-webpack-plugin');
2+
const path = require('path');
3+
14
module.exports = {
25
addons: [
36
'@storybook/addon-a11y',
@@ -6,7 +9,8 @@ module.exports = {
69
'@storybook/addon-knobs',
710
'@storybook/addon-links',
811
'storybook-design-token',
9-
'@storybook/addon-viewport'
12+
'@storybook/addon-viewport',
13+
'storybook-addon-styled-component-theme/dist/preset'
1014
],
1115
framework: '@storybook/react',
1216
core: {
@@ -16,7 +20,8 @@ module.exports = {
1620
config.resolve.plugins = [
1721
...(config.resolve.plugins || []),
1822
new TsconfigPathsPlugin({
19-
extensions: config.resolve.extensions
23+
extensions: config.resolve.extensions,
24+
configFile: path.resolve('tsconfig.json')
2025
})
2126
];
2227
return config;

templates/common/storybook/package.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,17 @@
1717
"@storybook/addon-knobs": "^6.4.0",
1818
"@storybook/addon-links": "^6.4.18",
1919
"@storybook/addon-viewport": "^6.4.18",
20+
"@storybook/builder-webpack5": "^6.4.18",
2021
"@storybook/cli": "^6.4.18",
22+
"@storybook/manager-webpack5": "^6.4.18",
2123
"@storybook/react": "^6.4.18",
2224
"@types/styled-components": "^5.1.22",
2325
"tsconfig-paths-webpack-plugin": "^3.5.2",
26+
"storybook-addon-styled-component-theme": "^2.0.0",
2427
"storybook-design-token": "^1.2.2",
2528
"styled-components": "^5.3.1"
29+
},
30+
"devDependencies": {
31+
"tsconfig": "*"
2632
}
2733
}
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"extends": "tsconfig/base.json",
3+
"compilerOptions": {
4+
"baseUrl": "."
5+
}
6+
}

templates/root/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@
1414
"@commitlint/cli": "^16.2.1",
1515
"@commitlint/config-angular": "^16.2.1",
1616
"@commitlint/prompt-cli": "^16.2.1",
17-
"@xt-pagesource/generate-plop": "^1.1.0",
17+
"@xt-pagesource/generate-plop": "^1.1.1",
1818
"husky": "^4.3.8",
1919
"ts-jest": "^27.1.3",
20-
"prettier": "^2.5.1"
20+
"prettier": "^2.5.1",
21+
"webpack": "^5.70.0"
2122
}
2223
}

0 commit comments

Comments
 (0)