Remove ContextDeriver and related functions #430
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added as a way to create a detatched context for async schedulers that still had some of the values of the original. Starting in Go 1.21, the standard library now provides the WithoutCancel function to make a copy of the values in a context but with a different lifetime. Custom implementations of ContextDervier are likely very rare (if they exist at all) and their main purpose would be to copy context values other than the logger. Since WithoutCancel now copies all values, I don't see any reason to keep supporting custom functions. While we could deprecate the existing functions, their rare usage combined with the fact that we frequently release breaking changes for go-github upgrades makes me believe this is safe.
|
Note that this isn't causing any problems I'm aware of, but I was reading something unrelated last week and learned about |
asvoboda
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added as a way to create a detatched context for async schedulers that still had some of the values of the original. Starting in Go 1.21, the standard library now provides the WithoutCancel function to make a copy of the values in a context but with a different lifetime.
Custom implementations of ContextDervier are likely very rare (if they exist at all) and their main purpose would be to copy context values other than the logger. Since WithoutCancel now copies all values, I don't see any reason to keep supporting custom functions.
While we could deprecate the existing functions, their rare usage combined with the fact that we frequently release breaking changes for go-github upgrades makes me believe this is safe.
Closes #428.