Merge pull request #718 from jbusecke/remove-ds.dims-warning

Crush warning about ds.dims deprecation

Author: norlandrhagen

pangeo_forge_recipes/rechunking.py

@@ -57,15 +57,15 @@ def split_fragment(
             dimsize = getattr(index[concat_dim], "dimsize", 0)
             concat_position = index[concat_dim]
             start = concat_position.value
-            stop = start + ds.dims[dim_name]
+            stop = start + ds.sizes[dim_name]
             dim_slice = slice(start, stop)
             rechunked_concat_dims.append(concat_dim)
         else:
             # If there is a target_chunk that is NOT present as a concat_dim
             # in the fragment index, then we can assume that the entire span of
             # that dimension is present in the dataset.
             # This would arise e.g. when decimating a contiguous dimension
-            dimsize = ds.dims[dim_name]
+            dimsize = ds.sizes[dim_name]
             dim_slice = slice(0, dimsize)
 
         target_chunks_and_dims[dim_name] = (chunk, dimsize)

tests/test_rechunking.py

@@ -142,7 +142,7 @@ def test_split_multidim():
 
     nt = 2
     ds = make_ds(nt=nt)
-    nlat = ds.dims["lat"]
+    nlat = ds.sizes["lat"]
     dimension = Dimension("time", CombineOp.CONCAT)
     index = Index({dimension: IndexedPosition(0, dimsize=nt)})
 
@@ -211,7 +211,7 @@ def test_combine_fragments_multidim(time_chunk, lat_chunk):
 
     nt = 10
     ds = make_ds(nt=nt)
-    ny = ds.dims["lat"]
+    ny = ds.sizes["lat"]
 
     fragments = []
     time_dim = Dimension("time", CombineOp.CONCAT)

tests/test_transforms.py

@@ -209,7 +209,7 @@ def test_rechunk(
     def correct_chunks():
         def _check_chunks(actual):
             for index, ds in actual:
-                actual_chunked_dims = {dim: ds.dims[dim] for dim in target_chunks}
+                actual_chunked_dims = {dim: ds.sizes[dim] for dim in target_chunks}
                 assert all(
                     position.indexed
                     for dimension, position in index.items()