Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no setting for concealing tripple equals or tripple not equals #1154

Closed
1ak31sha opened this issue Dec 18, 2018 · 4 comments · May be fixed by #1155
Closed

no setting for concealing tripple equals or tripple not equals #1154

1ak31sha opened this issue Dec 18, 2018 · 4 comments · May be fixed by #1155

Comments

@1ak31sha
Copy link

Requisite minimal reproducible example, formatted as plain text :

Optional: concerning jsx.

PLEASE PLEASE PLEASE make sure you have properly
setup and are sourcing this plugin https://github.com/mxw/vim-jsx

WE DO NOT support JSX automatically, you need another plugin to add get this
functionality.

Make sure the bug still exists if you disable all other javascript plugins
except the one noted above, mxw/vim-jsx
@bounceme
Copy link
Collaborator

bounceme commented Dec 19, 2018 •
edited
Loading

hmm, is double == concealable? if so then i'd say it's a bug, otherwise a feature request, ( pr's welcome )

@1ak31sha
Copy link
Author

1ak31sha commented Dec 19, 2018 •
edited
Loading

@bounceme i agree, this is a feature request, how can i label it so?

@nicanordlc
Copy link

@bounceme I think I can take this one 😬

@1ak31sha
Copy link
Author

update: i now use fira font which supports ligatures, such as triple equals, so i dont need to conceal anymore!

@amadeus amadeus closed this as completed Jan 17, 2019
@nicanordlc nicanordlc mentioned this issue Jan 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add conceal to double and tripple equal nicanordlc/vim-javascript
4 participants
@amadeus @bounceme @nicanordlc @1ak31sha