Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popovers are showing HTML markup #8727

Closed
mel-miller opened this issue Oct 6, 2023 · 0 comments · Fixed by #8732
Closed

Popovers are showing HTML markup #8727

mel-miller opened this issue Oct 6, 2023 · 0 comments · Fixed by #8732
Assignees
Labels
Source: Pantheor Contribution from within Pantheon, unspecified team

Comments

@mel-miller
Copy link
Member

Expected behavior

  • A popover/tooltip should display the actual content, not the markup.

Actual behavior

Screenshot 2023-10-06 at 11 51 03 AM

Steps to reproduce the problem

  1. Go to this page and hover on one of the tooltips: https://docs.pantheon.io/guides/support/

Suggested Resolution

During the PDS re-theme, the existing Popovers were mapped to the PDS Tooltip component. The Tooltip only takes a string as the prop for content as that is the scope of a tooltip. I was unware that some existing Popovers contained html markup such as lists and links.

My planned resolution is to expedite the development of a true Popover component (currently in the PDS backlog) and implement it here instead of the Tooltip.

@mel-miller mel-miller added Type: Fix Content Issue or PR to resolve incorrect information in the docs Source: Pantheor Contribution from within Pantheon, unspecified team and removed Type: Fix Content Issue or PR to resolve incorrect information in the docs labels Oct 6, 2023
@mel-miller mel-miller self-assigned this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Pantheor Contribution from within Pantheon, unspecified team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant